linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sundar Iyer <sundar.iyer@stericsson.com>
Cc: linux-input@vger.kernel.org,
	Linus Walleij <linus.walleij@stericsson.com>
Subject: Re: [PATCH v6 1/2] input: add support for Nomadik SKE keypad controller
Date: Wed, 22 Sep 2010 08:29:38 -0700	[thread overview]
Message-ID: <20100922152938.GA32097@core.coreip.homeip.net> (raw)
In-Reply-To: <1285156355-24555-1-git-send-email-sundar.iyer@stericsson.com>

On Wed, Sep 22, 2010 at 05:22:35PM +0530, Sundar Iyer wrote:
> Add support for the keypad controller in the Scroll Key Encoder (SKE)
> module on the Nomadik family and the DB8500 SoC.
> 
> Acked-by: Linus Walleij <linus.walleij@stericsson.com>
> Signed-off-by: Sundar Iyer <sundar.iyer@stericsson.com>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> ---
> >-----Original Message-----
> >From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> >Sent: Wednesday, September 22, 2010 2:02 PM
> 
> [..]
> 
> >below). If this does not work then I guess we'll have to rever to your original
> >approach with threaded IRQ (just drop the attached patch on top).
> 
> Dmitry,
> 
> I finally reverted back to your suggested patch for using the threaded irqs
> and its working again.
> 

Sundar,

Out of curiosity, did you try the patch that did not do polling? What
was the breakage?

I was also hoping you'd use it as a base for applying the threaded patch
- I did a few fixups and changed the probe routine a bit.

Thanks.

-- 
Dmitry

  reply	other threads:[~2010-09-22 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-22 11:52 [PATCH v6 1/2] input: add support for Nomadik SKE keypad controller Sundar Iyer
2010-09-22 15:29 ` Dmitry Torokhov [this message]
2010-09-23  5:17   ` Sundar R IYER

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100922152938.GA32097@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-input@vger.kernel.org \
    --cc=sundar.iyer@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).