From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Drake <dsd@laptop.org>
Cc: linux-input@vger.kernel.org, pgf@laptop.org
Subject: Re: [PATCH 1/3] Input: hgpk - enable advanced mode through module parameter
Date: Mon, 4 Oct 2010 10:45:34 -0700 [thread overview]
Message-ID: <20101004174533.GC8321@core.coreip.homeip.net> (raw)
In-Reply-To: <20101002204235.052959D401B@zog.reactivated.net>
Hi Daniel,
On Sat, Oct 02, 2010 at 09:42:34PM +0100, Daniel Drake wrote:
> +
> + /*
> + * The first packet after the finger goes down only establishes the
> + * baseline for relative movement.
> + * (ignore possibility of finger going down and button being pressed
> + * simultaneously.)
> + */
> + if (!priv->isdown) {
> + priv->abs_x = *x;
> + priv->abs_y = *y;
> + priv->isdown = true;
> + return false;
> + }
> +
> + tmp = *x; *x -= priv->abs_x; priv->abs_x = tmp;
> + tmp = *y; *y -= priv->abs_y; priv->abs_y = tmp;
Why do you use abs->rel conversion in driver and not rely on the
standard userspace component handling thouchpads in absolute mode?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-10-04 17:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 20:42 [PATCH 1/3] Input: hgpk - enable advanced mode through module parameter Daniel Drake
2010-10-04 17:45 ` Dmitry Torokhov [this message]
2010-10-04 18:27 ` Paul Fox
2010-10-04 18:33 ` Dmitry Torokhov
2010-10-05 16:59 ` Daniel Drake
2010-10-05 17:23 ` Dmitry Torokhov
2010-10-13 18:15 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004174533.GC8321@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dsd@laptop.org \
--cc=linux-input@vger.kernel.org \
--cc=pgf@laptop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).