From: Antonio Ospite <ospite@studenti.unina.it>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
Alan Ott <alan@signal11.us>, Oliver Neukum <oliver@neukum.name>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 0/2] HID: hidraw, fix two NULL pointer dereferences
Date: Sat, 9 Oct 2010 14:40:26 +0200 [thread overview]
Message-ID: <20101009144026.c37f8d25.ospite@studenti.unina.it> (raw)
In-Reply-To: <4CAC4AC3.60507@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
On Wed, 06 Oct 2010 12:09:07 +0200
Jiri Slaby <jirislaby@gmail.com> wrote:
> On 10/06/2010 12:01 PM, Antonio Ospite wrote:
> > On Tue, 05 Oct 2010 23:12:00 +0200
> > Jiri Slaby <jirislaby@gmail.com> wrote:
[...]
> >> Hi, please fix also the window in hidraw_release.
> >>
> >
> > I am not sure I get what you mean, can you please add more details?
>
> Sure. Look at the code:
> if (!hidraw_table[minor])
> return -ENODEV;
> ...
> dev = hidraw_table[minor];
> if (!--dev->open) {
> ...
>
> This is done without minors_lock, so you can easily have dev being NULL
> even though the first if.
>
Jiri (Slaby) I think it makes more sense if you send a patch about this
as it is you who has raised the issue.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-10-09 12:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 11:25 [PATCH] HID: hidraw, fix a NULL pointer dereference in hidraw_ioctl Antonio Ospite
2010-10-04 13:50 ` Jiri Kosina
2010-10-04 14:11 ` Antonio Ospite
2010-10-05 15:20 ` [PATCH 0/2] HID: hidraw, fix two NULL pointer dereferences Antonio Ospite
2010-10-05 17:42 ` [stable] " Greg KH
2010-10-05 20:16 ` Antonio Ospite
2010-10-06 9:31 ` Jiri Kosina
2010-10-15 7:44 ` Antonio Ospite
2010-10-15 9:10 ` Jiri Kosina
2010-10-05 21:12 ` Jiri Slaby
2010-10-06 10:01 ` Antonio Ospite
2010-10-06 10:09 ` Jiri Slaby
2010-10-09 12:40 ` Antonio Ospite [this message]
2010-10-19 9:24 ` [PATCH 1/1] HID: hidraw, fix window in hidraw_release Jiri Slaby
2010-10-19 9:28 ` Jiri Slaby
2010-10-19 9:29 ` Jiri Slaby
2010-10-20 14:55 ` Jiri Kosina
2010-10-05 15:20 ` [PATCH 1/2] HID: hidraw, fix a NULL pointer dereference in hidraw_ioctl Antonio Ospite
2010-10-05 15:20 ` [PATCH 2/2] HID: hidraw, fix a NULL pointer dereference in hidraw_write Antonio Ospite
2010-10-04 13:54 ` [PATCH] HID: hidraw, fix a NULL pointer dereference in hidraw_ioctl Alan Ott
2010-10-05 20:29 ` Antonio Ospite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101009144026.c37f8d25.ospite@studenti.unina.it \
--to=ospite@studenti.unina.it \
--cc=alan@signal11.us \
--cc=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.name \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).