From: Jarod Wilson <jarod@redhat.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: lirc-list@lists.sourceforge.net,
"Jarod Wilson" <jarod@wilsonet.com>,
"David Härdeman" <david@hardeman.nu>,
mchehab@infradead.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 3/5] IR: ene_ir: few bugfixes
Date: Fri, 15 Oct 2010 16:02:12 -0400 [thread overview]
Message-ID: <20101015200212.GK9658@redhat.com> (raw)
In-Reply-To: <1287158799-21486-4-git-send-email-maximlevitsky@gmail.com>
On Fri, Oct 15, 2010 at 06:06:37PM +0200, Maxim Levitsky wrote:
> This is a result of last round of debug with
> Sami R <maesesami@gmail.com>.
>
> Thank you Sami very much!
>
> The biggest bug I fixed is that,
> I was clobbering the CIRCFG register after it is setup
> That wasn't a good idea really
>
> And some small refactoring, etc.
>
> Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
> ---
> drivers/media/IR/ene_ir.c | 43 ++++++++++++++++++++-----------------------
> 1 files changed, 20 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c
> index dc32509..8639621 100644
> --- a/drivers/media/IR/ene_ir.c
> +++ b/drivers/media/IR/ene_ir.c
...
> @@ -282,6 +287,7 @@ static void ene_rx_setup(struct ene_device *dev)
> ene_set_reg_mask(dev, ENE_CIRCFG, ENE_CIRCFG_CARR_DEMOD);
>
> /* Enable carrier detection */
> + ene_write_reg(dev, ENE_CIRCAR_PULS, 0x63);
Looks sane, though I'd prefer to see symbolic bit names or some such thing
here instead of 0x63. Not something to hold up the patch though.
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2010-10-15 20:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 16:06 [PATCH 0/8 V7] Many fixes for in-kernel decoding and for the ENE driver Maxim Levitsky
[not found] ` <1287158799-21486-1-git-send-email-maximlevitsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-15 16:06 ` [PATCH 1/5] IR: extend and sort the MCE keymap Maxim Levitsky
2010-10-15 19:48 ` Jarod Wilson
2010-10-15 16:06 ` [PATCH 2/5] IR: extend ir_raw_event and do refactoring Maxim Levitsky
2010-10-16 3:29 ` Mauro Carvalho Chehab
2010-10-16 4:11 ` Maxim Levitsky
2010-10-15 16:06 ` [PATCH 3/5] IR: ene_ir: few bugfixes Maxim Levitsky
2010-10-15 20:02 ` Jarod Wilson [this message]
[not found] ` <20101015200212.GK9658-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-15 20:24 ` Maxim Levitsky
2010-10-15 21:00 ` Jarod Wilson
2010-10-15 16:06 ` [PATCH 4/5] IR: ene_ir: add support for carrier reports Maxim Levitsky
2010-10-15 20:16 ` Jarod Wilson
2010-10-16 3:31 ` Mauro Carvalho Chehab
2010-10-15 16:06 ` [PATCH 5/5] IR: ene_ir: don't upload all settings on each TX packet Maxim Levitsky
2010-10-16 3:23 ` [PATCH 0/8 V7] Many fixes for in-kernel decoding and for the ENE driver Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015200212.GK9658@redhat.com \
--to=jarod@redhat.com \
--cc=david@hardeman.nu \
--cc=jarod@wilsonet.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lirc-list@lists.sourceforge.net \
--cc=maximlevitsky@gmail.com \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).