From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarod Wilson Subject: Re: [PATCH 4/5] IR: ene_ir: add support for carrier reports Date: Fri, 15 Oct 2010 16:16:00 -0400 Message-ID: <20101015201600.GL9658@redhat.com> References: <1287158799-21486-1-git-send-email-maximlevitsky@gmail.com> <1287158799-21486-5-git-send-email-maximlevitsky@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1287158799-21486-5-git-send-email-maximlevitsky@gmail.com> Sender: linux-media-owner@vger.kernel.org To: Maxim Levitsky Cc: lirc-list@lists.sourceforge.net, Jarod Wilson , David =?iso-8859-1?Q?H=E4rdeman?= , mchehab@infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org List-Id: linux-input@vger.kernel.org On Fri, Oct 15, 2010 at 06:06:38PM +0200, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > drivers/media/IR/ene_ir.c | 37 +++++++++++++++++++++++++++++-------- > 1 files changed, 29 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c > index 8639621..1962652 100644 > --- a/drivers/media/IR/ene_ir.c > +++ b/drivers/media/IR/ene_ir.c ... > @@ -209,13 +210,16 @@ void ene_rx_sense_carrier(struct ene_device *dev) > dbg("RX: hardware carrier period = %02x", period); > dbg("RX: hardware carrier pulse period = %02x", hperiod); > > - > carrier = 2000000 / period; > duty_cycle = (hperiod * 100) / period; > dbg("RX: sensed carrier = %d Hz, duty cycle %d%%", > - carrier, duty_cycle); > - > - /* TODO: Send carrier & duty cycle to IR layer */ > + carrier, duty_cycle); Spacing is a bit odd here (random indent, no newline), but meh, looks sane otherwise. > + if (dev->carrier_detect_enabled) { > + ev.carrier_report = true; > + ev.carrier = carrier; > + ev.duty_cycle = duty_cycle; > + ir_raw_event_store(dev->idev, &ev); > + } > } > > /* this enables/disables the CIR RX engine */ Acked-by: Jarod Wilson -- Jarod Wilson jarod@redhat.com