From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: michael.hennerich@analog.com, drivers@analog.com,
device-drivers-devel@blackfin.uclinux.org,
linux-input@vger.kernel.org
Subject: Re: [Device-drivers-devel] [PATCH 3/3] Input: touchscreen: ad7877 filter events where pressure is beyond the maximum
Date: Sun, 17 Oct 2010 21:08:10 -0700 [thread overview]
Message-ID: <20101018040810.GB7782@core.coreip.homeip.net> (raw)
In-Reply-To: <AANLkTimg2Uv26dcU7noSGCX7SHOn2+p6-LH_q=h9NtWc@mail.gmail.com>
On Fri, Oct 15, 2010 at 09:51:12PM -0400, Mike Frysinger wrote:
> On Fri, Oct 15, 2010 at 06:40, <michael.hennerich@analog.com> wrote:
> > Suppress events where pressure > pressure_max.
> > These events come typically along with inaccurate X and Y samples.
>
> were you going to commit to the blackfin tree ?
>
> > --- a/drivers/input/touchscreen/ad7877.c
> > +++ b/drivers/input/touchscreen/ad7877.c
> > @@ -360,6 +360,13 @@ static int ad7877_rx(struct ad7877 *ts)
> > Rt /= z1;
> > Rt = (Rt + 2047) >> 12;
> >
> > + /*
> > + * Sample found inconsistent, pressure is beyond
> > + * the maximum. Don't report it to user space.
> > + */
> > + if (Rt > ts->pressure_max)
> > + return -EINVAL;
>
> this has spaces in the middle of your tab indents ...
I took care of that on my side...
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-10-18 4:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 10:40 [PATCH 1/3] Input: touchscreen: ad7877 implement specified chip select behavior michael.hennerich
2010-10-15 10:40 ` [PATCH 2/3] Input: touchscreen: ad7877 implement EV_KEY:BTN_TOUCH reporting michael.hennerich
2010-10-15 10:40 ` [PATCH 3/3] Input: touchscreen: ad7877 filter events where pressure is beyond the maximum michael.hennerich
2010-10-16 1:51 ` [Device-drivers-devel] " Mike Frysinger
2010-10-18 4:08 ` Dmitry Torokhov [this message]
2010-10-18 4:24 ` Dmitry Torokhov
2010-10-18 4:25 ` Dmitry Torokhov
2010-10-18 8:13 ` Hennerich, Michael
2010-10-18 8:22 ` Dmitry Torokhov
2010-10-18 8:12 ` Hennerich, Michael
2010-10-15 16:56 ` [PATCH 1/3] Input: touchscreen: ad7877 implement specified chip select behavior Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018040810.GB7782@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=linux-input@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).