* [PATCH] input: adp5588-keys: use obvious i2c_device_id name string
@ 2010-10-18 22:23 Mike Frysinger
2010-10-22 16:35 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2010-10-18 22:23 UTC (permalink / raw)
To: linux-input, Dmitry Torokhov; +Cc: device-drivers-devel, Michael Hennerich
From: Michael Hennerich <michael.hennerich@analog.com>
KBUILD_MODNAME normalizes "-" to "_". This is non-obvious and results in
the id name for ADP5588 being "adp5588_keys" while the other supported id
is "adp5587-keys". So avoid this define and use an explicit string as the
id name.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
drivers/input/keyboard/adp5588-keys.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
index d6918cb..b92d1cd 100644
--- a/drivers/input/keyboard/adp5588-keys.c
+++ b/drivers/input/keyboard/adp5588-keys.c
@@ -660,7 +660,7 @@ static const struct dev_pm_ops adp5588_dev_pm_ops = {
#endif
static const struct i2c_device_id adp5588_id[] = {
- { KBUILD_MODNAME, 0 },
+ { "adp5588-keys", 0 },
{ "adp5587-keys", 0 },
{ }
};
--
1.7.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] input: adp5588-keys: use obvious i2c_device_id name string
2010-10-18 22:23 [PATCH] input: adp5588-keys: use obvious i2c_device_id name string Mike Frysinger
@ 2010-10-22 16:35 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2010-10-22 16:35 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-input, device-drivers-devel, Michael Hennerich
On Mon, Oct 18, 2010 at 06:23:00PM -0400, Mike Frysinger wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> KBUILD_MODNAME normalizes "-" to "_". This is non-obvious and results in
> the id name for ADP5588 being "adp5588_keys" while the other supported id
> is "adp5587-keys". So avoid this define and use an explicit string as the
> id name.
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-22 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-18 22:23 [PATCH] input: adp5588-keys: use obvious i2c_device_id name string Mike Frysinger
2010-10-22 16:35 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).