From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use
Date: Tue, 26 Oct 2010 20:00:37 -0700 [thread overview]
Message-ID: <20101027030037.GA19202@core.coreip.homeip.net> (raw)
In-Reply-To: <1288143345.4145.90.camel@Joe-Laptop>
On Tue, Oct 26, 2010 at 06:35:45PM -0700, Joe Perches wrote:
> On Tue, 2010-10-26 at 18:28 -0700, Dmitry Torokhov wrote:
> > On Oct 26, 2010, at 6:10 PM, Joe Perches <joe@perches.com> wrote:
> > > I think 2 defects in 16 uses is a pretty high error rate.
> > But how not adding /n is it much better than having it if
> > some later change will forget to add it to the message?
>
> Adding \n is the default kernel style.
>
> USB uses a similar dbg macro with a relatively
> high error rate.
>
> I fixed some in this commit below awhile ago,
> but these keep creeping back in, so they _are_
> error prone in actual use.
>
OK, fair enough.
Thanks.
--
Dmitry
prev parent reply other threads:[~2010-10-27 3:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 2:44 [PATCH 00/10] Remove multiple uses of KERN_<level> Joe Perches
2010-10-26 2:44 ` [PATCH 03/10] drivers/hid/hid-input.c: Remove KERN_DEBUG from dbg_hid use Joe Perches
2010-11-03 14:13 ` Jiri Kosina
2010-10-26 2:44 ` [PATCH 05/10] drivers/input/mouse/appletouch.c: Remove KERN_DEBUG use from dprintk Joe Perches
2010-10-26 15:52 ` Dmitry Torokhov
2010-10-26 2:44 ` [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use Joe Perches
2010-10-26 15:50 ` Dmitry Torokhov
2010-10-26 23:25 ` Joe Perches
2010-10-27 0:40 ` Dmitry Torokhov
2010-10-27 0:46 ` Joe Perches
2010-10-27 1:00 ` Dmitry Torokhov
2010-10-27 1:10 ` Joe Perches
2010-10-27 1:28 ` Dmitry Torokhov
2010-10-27 1:35 ` Joe Perches
2010-10-27 3:00 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027030037.GA19202@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=joe@perches.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).