From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_, pr_fmt. Fix dbg and __FILE__ use Date: Tue, 26 Oct 2010 20:00:37 -0700 Message-ID: <20101027030037.GA19202@core.coreip.homeip.net> References: <20101026155028.GA13097@core.coreip.homeip.net> <1288135531.4145.59.camel@Joe-Laptop> <201010261740.13566.dmitry.torokhov@gmail.com> <1288140416.4145.76.camel@Joe-Laptop> <1288141825.4145.83.camel@Joe-Laptop> <4E27039C-DE6B-4C90-ADC5-68D3B30F75E6@gmail.com> <1288143345.4145.90.camel@Joe-Laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-gw0-f46.google.com ([74.125.83.46]:62485 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933102Ab0J0DAo (ORCPT ); Tue, 26 Oct 2010 23:00:44 -0400 Content-Disposition: inline In-Reply-To: <1288143345.4145.90.camel@Joe-Laptop> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Joe Perches Cc: Jiri Kosina , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" On Tue, Oct 26, 2010 at 06:35:45PM -0700, Joe Perches wrote: > On Tue, 2010-10-26 at 18:28 -0700, Dmitry Torokhov wrote: > > On Oct 26, 2010, at 6:10 PM, Joe Perches wrote: > > > I think 2 defects in 16 uses is a pretty high error rate. > > But how not adding /n is it much better than having it if > > some later change will forget to add it to the message? > > Adding \n is the default kernel style. > > USB uses a similar dbg macro with a relatively > high error rate. > > I fixed some in this commit below awhile ago, > but these keep creeping back in, so they _are_ > error prone in actual use. > OK, fair enough. Thanks. -- Dmitry