From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Arce, Abraham" <x0066660@ti.com>
Cc: Naveen Kumar GADDIPATI <naveen.gaddipati@stericsson.com>,
Linus WALLEIJ <linus.walleij@stericsson.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
STEricsson_nomadik_linux <STEricsson_nomadik_linux@list.st.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: Re: [PATCHv1] staging: Synaptics RMI4 touchpad driver support
Date: Thu, 4 Nov 2010 04:31:08 -0700 [thread overview]
Message-ID: <20101104113108.GA27223@core.coreip.homeip.net> (raw)
In-Reply-To: <27F9C60D11D683428E133F85D2BB4A530468A82CF3@dlee03.ent.ti.com>
Hi Arce,
On Thu, Nov 04, 2010 at 12:45:45AM -0500, Arce, Abraham wrote:
> Hi Naveen, Dmitry,
>
> > From: Naveen Kumar GADDIPATI [mailto:naveen.gaddipati@stericsson.com]
> >
> > Hi Arce,
> >
> > I'm also the GPIO pin for interrupt with request threaded irq .
> > I'm passing the irq_type from the platform data.
> > Which irq_type are you using for your platform?
> >
>
> I am using the following flags
>
> IRQF_DISABLED | IRQF_TRIGGER_LOW | IRQF_TRIGGER_FALLING
>
> Should I get rid of the first one, IRQF_DISABLED?
>
> IRQF_DISABLED - keep irqs disabled when calling the action handler
>
You probably want IRQF_TRIGGER_LOW | IRQF_ONESHOT if your interrupt is
level tiggered.
IRQF_TRIGGER_LOW | IRQF_TRIGGER_FALLING mixes edge and level options and
thus I don't think is proper.
--
Dmitry
prev parent reply other threads:[~2010-11-04 11:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1288699725-14405-1-git-send-email-naveen.gaddipati@stericsson.com>
[not found] ` <20101102140337.GC9387@kroah.com>
2010-11-02 14:14 ` [PATCHv1] staging: Synaptics RMI4 touchpad driver support Linus Walleij
2010-11-02 15:20 ` Greg KH
2010-11-02 15:40 ` Dmitry Torokhov
2010-11-03 18:10 ` Greg KH
2010-11-03 19:07 ` Dmitry Torokhov
2010-11-03 19:19 ` Greg KH
2010-11-03 21:37 ` Arce, Abraham
2010-11-04 4:14 ` Dmitry Torokhov
2010-11-04 5:36 ` Naveen Kumar GADDIPATI
2010-11-04 5:45 ` Arce, Abraham
2010-11-04 5:59 ` Naveen Kumar GADDIPATI
2010-11-04 11:31 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101104113108.GA27223@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=greg@kroah.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.gaddipati@stericsson.com \
--cc=x0066660@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).