Touchpad toggle mess

Touchpad toggle mess

[Bastien Nocera]

[-- Attachment #1: Type: text/plain, Size: 3118 bytes --]

Heya,

In GNOME 2.32, we added support for touchpad toggle buttons, by
capturing the XF86TouchpadToggle button in gnome-settings-daemon,
showing a nice popup, and disabling the touchpad in software.

That works great for a number of laptops, but completely breaks a number
of others where the hardware handles the request, but still sends a key
event (usually separate ones for on and off). In those cases, we'd need
2 more key types, in the kernel, and in X.org.

The patches in https://bugs.freedesktop.org/show_bug.cgi?id=31300
implement this for the kernel, and for X.org.

Then we have the problem that udev's keymaps seem to use different
function keys depending on the hardware [1], when X.org (because of the
limitations of XKB) standardised on F22 for "XF86TouchpadToggle".

So we'll need to standardise on the keys used. I selected F21 for
XF86TouchpadToggle, F22 for XF86TouchpadOn and F23 for XF86TouchpadOff.
See the patch in:
https://bugs.freedesktop.org/show_bug.cgi?id=31333

The remaining fixes would need to be in udev's keymaps, to set hardware
handled keys to F22 and F23, and software ones to F21. Patch is attached
for that.

Questions, comments?

[1]: F21, F22, or F23 then?
$ grep -ri touchpad extras/keymap/keymaps/
extras/keymap/keymaps/lenovo-thinkpad-usb-keyboard-trackpoint:0x90017 f22 # Fn+F8  touchpadtoggle
extras/keymap/keymaps/zepto-znote:0xA5 f22                # Fn+F6 Disable Touchpad
extras/keymap/keymaps/zepto-znote:0xA6 f22                # Fn+F6 Enable Touchpad
extras/keymap/keymaps/hewlett-packard-pavilion:0xD8 f22 # touchpad off
extras/keymap/keymaps/hewlett-packard-pavilion:0xD9 f23 # touchpad on
extras/keymap/keymaps/dell:0x9E f22 #touchpad toggle
extras/keymap/keymaps/dell:0xD9 f22 # touchpad toggle
extras/keymap/keymaps/samsung-other:0xF7 f22 # Fn+F10 Touchpad on
extras/keymap/keymaps/samsung-other:0xF9 f22 # Fn+F10 Touchpad off
extras/keymap/keymaps/hewlett-packard-tx2:0xD8 f22 # Toggle touchpad button on tx2 (OFF)
extras/keymap/keymaps/hewlett-packard-tx2:0xD9 f22 # Toggle touchpad button on tx2 (ON)
extras/keymap/keymaps/everex-xt5000:0x65 f22 # Fn+F5 Touchpad toggle
extras/keymap/keymaps/samsung-sx20s:0x77 f21 # FIXME: Touchpad on
extras/keymap/keymaps/samsung-sx20s:0x79 f21 # FIXME: Touchpad off
extras/keymap/keymaps/onkyo:0xF7 f22 # Fn+Y (touchpad toggle)
extras/keymap/keymaps/toshiba-satellite_a110:0x9E f21 # FIXME: Touchpad on
extras/keymap/keymaps/toshiba-satellite_a110:0x9F f21 # FIXME: Touchpad off
extras/keymap/keymaps/toshiba-satellite_m30x:0x9e prog1 #touchpad_enable
extras/keymap/keymaps/toshiba-satellite_m30x:0x9f prog2 #touchpad_disable
extras/keymap/keymaps/acer:0xF1 f22 # Fn+F7 Touchpad toggle (off-to-on)
extras/keymap/keymaps/acer:0xF2 f22 # Fn+F7 Touchpad toggle (on-to-off)
extras/keymap/keymaps/micro-star:0xE4 f22 # Fn-F3   Touchpad disable
extras/keymap/keymaps/module-lenovo:0x7 f22 # Fn+F8 touchpadtoggle
extras/keymap/keymaps/lg-x110:0xE4 f22 # Fn-F5   Touchpad disable
extras/keymap/keymaps/hewlett-packard-2510p_2530p:0xD8 f22 # touchpad off
extras/keymap/keymaps/hewlett-packard-2510p_2530p:0xD9 f23 # touchpad on


[-- Attachment #2: 0001-extras-keymap-Fix-touchpad-toggle-buttons-used.patch --]
[-- Type: text/x-patch, Size: 8503 bytes --]

>From 52118a82743e4ca65d5be01c304685d265b5f7a7 Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Thu, 4 Nov 2010 23:58:56 +0000
Subject: [PATCH] extras/keymap: Fix touchpad toggle buttons used

See:
https://bugs.freedesktop.org/show_bug.cgi?id=31333
---
 extras/keymap/keymaps/acer                         |    2 +-
 extras/keymap/keymaps/dell                         |    4 ++--
 extras/keymap/keymaps/everex-xt5000                |    2 +-
 extras/keymap/keymaps/hewlett-packard-2510p_2530p  |    4 ++--
 extras/keymap/keymaps/hewlett-packard-pavilion     |    4 ++--
 extras/keymap/keymaps/hewlett-packard-tx2          |    2 +-
 .../lenovo-thinkpad-usb-keyboard-trackpoint        |    2 +-
 extras/keymap/keymaps/lg-x110                      |    4 ++--
 extras/keymap/keymaps/micro-star                   |    2 +-
 extras/keymap/keymaps/module-lenovo                |    2 +-
 extras/keymap/keymaps/onkyo                        |    2 +-
 extras/keymap/keymaps/samsung-other                |    2 +-
 extras/keymap/keymaps/samsung-sx20s                |    4 ++--
 extras/keymap/keymaps/toshiba-satellite_a110       |    4 ++--
 extras/keymap/keymaps/toshiba-satellite_m30x       |    4 ++--
 extras/keymap/keymaps/zepto-znote                  |    2 +-
 16 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/extras/keymap/keymaps/acer b/extras/keymap/keymaps/acer
index 6abe39c..4e7c297 100644
--- a/extras/keymap/keymaps/acer
+++ b/extras/keymap/keymaps/acer
@@ -14,7 +14,7 @@
 0xEE brightnessup # Fn+Right
 0xEF brightnessdown # Fn+Left
 0xF1 f22 # Fn+F7 Touchpad toggle (off-to-on)
-0xF2 f22 # Fn+F7 Touchpad toggle (on-to-off)
+0xF2 f23 # Fn+F7 Touchpad toggle (on-to-off)
 0xF3 prog2 # "P2" programmable button
 0xF4 prog1 # "P1" programmable button
 0xF5 presentation
diff --git a/extras/keymap/keymaps/dell b/extras/keymap/keymaps/dell
index 1a2e433..fbbb903 100644
--- a/extras/keymap/keymaps/dell
+++ b/extras/keymap/keymaps/dell
@@ -21,9 +21,9 @@
 0x99 nextsong # Front panel next song
 0x9A setup # Tablet tools button
 0x9B switchvideomode # Display Toggle button
-0x9E f22 #touchpad toggle
+0x9E f21 #touchpad toggle
 0xA2 playpause # Front panel play/pause
 0xA4 stopcd # Front panel stop
 0xED media # MediaDirect button
 0xD8 screenlock # FIXME: Tablet lock button
-0xD9 f22 # touchpad toggle
+0xD9 f21 # touchpad toggle
diff --git a/extras/keymap/keymaps/everex-xt5000 b/extras/keymap/keymaps/everex-xt5000
index 53bdd7a..4823a83 100644
--- a/extras/keymap/keymaps/everex-xt5000
+++ b/extras/keymap/keymaps/everex-xt5000
@@ -1,5 +1,5 @@
 0x5C media
-0x65 f22 # Fn+F5 Touchpad toggle
+0x65 f21 # Fn+F5 Touchpad toggle
 0x67 prog3 # Fan Speed Control button
 0x6F brightnessup
 0x7F brightnessdown
diff --git a/extras/keymap/keymaps/hewlett-packard-2510p_2530p b/extras/keymap/keymaps/hewlett-packard-2510p_2530p
index 2bc70c2..41ad2e9 100644
--- a/extras/keymap/keymaps/hewlett-packard-2510p_2530p
+++ b/extras/keymap/keymaps/hewlett-packard-2510p_2530p
@@ -1,2 +1,2 @@
-0xD8 f22 # touchpad off
-0xD9 f23 # touchpad on
+0xD8 f23 # touchpad off
+0xD9 f22 # touchpad on
diff --git a/extras/keymap/keymaps/hewlett-packard-pavilion b/extras/keymap/keymaps/hewlett-packard-pavilion
index a55d2b7..3d3cefc 100644
--- a/extras/keymap/keymaps/hewlett-packard-pavilion
+++ b/extras/keymap/keymaps/hewlett-packard-pavilion
@@ -1,3 +1,3 @@
 0x88 media # FIXME: quick play
-0xD8 f22 # touchpad off
-0xD9 f23 # touchpad on
+0xD8 f23 # touchpad off
+0xD9 f22 # touchpad on
diff --git a/extras/keymap/keymaps/hewlett-packard-tx2 b/extras/keymap/keymaps/hewlett-packard-tx2
index 206c004..36a690f 100644
--- a/extras/keymap/keymaps/hewlett-packard-tx2
+++ b/extras/keymap/keymaps/hewlett-packard-tx2
@@ -1,3 +1,3 @@
 0xC2 media
-0xD8 f22 # Toggle touchpad button on tx2 (OFF)
+0xD8 f23 # Toggle touchpad button on tx2 (OFF)
 0xD9 f22 # Toggle touchpad button on tx2 (ON)
diff --git a/extras/keymap/keymaps/lenovo-thinkpad-usb-keyboard-trackpoint b/extras/keymap/keymaps/lenovo-thinkpad-usb-keyboard-trackpoint
index 7612f79..bc91470 100644
--- a/extras/keymap/keymaps/lenovo-thinkpad-usb-keyboard-trackpoint
+++ b/extras/keymap/keymaps/lenovo-thinkpad-usb-keyboard-trackpoint
@@ -2,7 +2,7 @@
 0x90013 battery # Fn+F3
 0x90014 wlan # Fn+F5
 0x90016 switchvideomode # Fn+F7
-0x90017 f22 # Fn+F8  touchpadtoggle
+0x90017 f21 # Fn+F8  touchpadtoggle
 0x90019 suspend # Fn+F12
 0x9001A brightnessup # Fn+Home
 0x9001B brightnessdown # Fn+End
diff --git a/extras/keymap/keymaps/lg-x110 b/extras/keymap/keymaps/lg-x110
index a61cf3d..ba08cba 100644
--- a/extras/keymap/keymaps/lg-x110
+++ b/extras/keymap/keymaps/lg-x110
@@ -6,7 +6,7 @@
 0xB3 suspend # Fn-F12
 0xDF sleep # Fn-F4
 # 0xE2 bluetooth # satellite dish2
-0xE4 f22 # Fn-F5   Touchpad disable
+0xE4 f21 # Fn-F5   Touchpad disable
 0xF6 wlan # Fn-F6
 0xF7 reserved # brightnessdown # Fn-Down
-0xF8 reserved # brightnessup # Fn-Up
\ No newline at end of file
+0xF8 reserved # brightnessup # Fn-Up
diff --git a/extras/keymap/keymaps/micro-star b/extras/keymap/keymaps/micro-star
index 0de5ae6..4a43869 100644
--- a/extras/keymap/keymaps/micro-star
+++ b/extras/keymap/keymaps/micro-star
@@ -4,7 +4,7 @@
 0xB2 www # e button
 0xDF sleep # Fn-F12
 0xE2 bluetooth # satellite dish2
-0xE4 f22 # Fn-F3   Touchpad disable
+0xE4 f21 # Fn-F3   Touchpad disable
 0xEC email # envelope button
 0xEE camera # Fn-F6 camera disable
 0xF6 wlan # satellite dish1
diff --git a/extras/keymap/keymaps/module-lenovo b/extras/keymap/keymaps/module-lenovo
index 7c597bd..9cb74b2 100644
--- a/extras/keymap/keymaps/module-lenovo
+++ b/extras/keymap/keymaps/module-lenovo
@@ -3,7 +3,7 @@
 0x3 sleep # Fn+F4
 0x4 wlan # Fn+F5
 0x6 switchvideomode # Fn+F7
-0x7 f22 # Fn+F8 touchpadtoggle
+0x7 f21 # Fn+F8 touchpadtoggle
 0x8 f24 # Fn+F9 undock
 0xB suspend # Fn+F12
 0xF brightnessup # Fn+Home
diff --git a/extras/keymap/keymaps/onkyo b/extras/keymap/keymaps/onkyo
index 7dd80a1..ee864ad 100644
--- a/extras/keymap/keymaps/onkyo
+++ b/extras/keymap/keymaps/onkyo
@@ -8,7 +8,7 @@
 0xF0 media # Fn+R
 0xF5 switchvideomode # Fn+E
 0xF6 camera # Fn+T
-0xF7 f22 # Fn+Y (touchpad toggle)
+0xF7 f21 # Fn+Y (touchpad toggle)
 0xF8 brightnessup # Fn+S
 0xF9 brightnessdown # Fn+A
 0xFB wlan # Fn+J
diff --git a/extras/keymap/keymaps/samsung-other b/extras/keymap/keymaps/samsung-other
index 6a0928c..3ac0c2f 100644
--- a/extras/keymap/keymaps/samsung-other
+++ b/extras/keymap/keymaps/samsung-other
@@ -11,4 +11,4 @@
 0xB3 prog3 # Fn+F8 switch power mode (battery/dynamic/performance)
 0xB4 wlan # Fn+F9 (X60P)
 0xF7 f22 # Fn+F10 Touchpad on
-0xF9 f22 # Fn+F10 Touchpad off
+0xF9 f23 # Fn+F10 Touchpad off
diff --git a/extras/keymap/keymaps/samsung-sx20s b/extras/keymap/keymaps/samsung-sx20s
index daf7d3e..9d954ee 100644
--- a/extras/keymap/keymaps/samsung-sx20s
+++ b/extras/keymap/keymaps/samsung-sx20s
@@ -1,4 +1,4 @@
 0x74 mute
 0x75 mute
-0x77 f21 # FIXME: Touchpad on
-0x79 f21 # FIXME: Touchpad off
+0x77 f22 # Touchpad on
+0x79 f23 # Touchpad off
diff --git a/extras/keymap/keymaps/toshiba-satellite_a110 b/extras/keymap/keymaps/toshiba-satellite_a110
index 0f2aaec..1429409 100644
--- a/extras/keymap/keymaps/toshiba-satellite_a110
+++ b/extras/keymap/keymaps/toshiba-satellite_a110
@@ -1,8 +1,8 @@
 0x92 stop
 0x93 www
 0x94 media
-0x9E f21 # FIXME: Touchpad on
-0x9F f21 # FIXME: Touchpad off
+0x9E f22 # Touchpad on
+0x9F f23 # Touchpad off
 0xB9 nextsong
 0xD9 brightnessup
 0xEE screenlock
diff --git a/extras/keymap/keymaps/toshiba-satellite_m30x b/extras/keymap/keymaps/toshiba-satellite_m30x
index cf6d912..9280ae0 100644
--- a/extras/keymap/keymaps/toshiba-satellite_m30x
+++ b/extras/keymap/keymaps/toshiba-satellite_m30x
@@ -2,6 +2,6 @@
 0xd9 brightnessup
 0xee screenlock
 0x93 media
-0x9e prog1 #touchpad_enable
-0x9f prog2 #touchpad_disable
+0x9e f22 #touchpad_enable
+0x9f f23 #touchpad_disable
 
diff --git a/extras/keymap/keymaps/zepto-znote b/extras/keymap/keymaps/zepto-znote
index e076516..cf72fda 100644
--- a/extras/keymap/keymaps/zepto-znote
+++ b/extras/keymap/keymaps/zepto-znote
@@ -1,7 +1,7 @@
 0x93 switchvideomode    # Fn+F3 Toggle Video Output
 0x95 brightnessdown     # Fn+F4 Brightness Down
 0x91 brightnessup       # Fn+F5 Brightness Up
-0xA5 f22                # Fn+F6 Disable Touchpad
+0xA5 f23                # Fn+F6 Disable Touchpad
 0xA6 f22                # Fn+F6 Enable Touchpad
 0xA7 bluetooth          # Fn+F10 Enable Bluetooth
 0XA9 bluetooth          # Fn+F10 Disable Bluetooth
-- 
1.7.3.2

Re: Touchpad toggle mess

[Dmitry Torokhov]

Hi Bastien,

On Fri, Nov 05, 2010 at 12:00:09AM +0000, Bastien Nocera wrote:
> Heya,
> 
> In GNOME 2.32, we added support for touchpad toggle buttons, by
> capturing the XF86TouchpadToggle button in gnome-settings-daemon,
> showing a nice popup, and disabling the touchpad in software.
> 
> That works great for a number of laptops, but completely breaks a number
> of others where the hardware handles the request, but still sends a key
> event (usually separate ones for on and off). In those cases, we'd need
> 2 more key types, in the kernel, and in X.org.

Rfkill story all over I guess ;(

> 
> The patches in https://bugs.freedesktop.org/show_bug.cgi?id=31300
> implement this for the kernel, and for X.org.
> 
> Then we have the problem that udev's keymaps seem to use different
> function keys depending on the hardware [1], when X.org (because of the
> limitations of XKB) standardised on F22 for "XF86TouchpadToggle".
> 
> So we'll need to standardise on the keys used. I selected F21 for
> XF86TouchpadToggle, F22 for XF86TouchpadOn and F23 for XF86TouchpadOff.
> See the patch in:
> https://bugs.freedesktop.org/show_bug.cgi?id=31333
> 
> The remaining fixes would need to be in udev's keymaps, to set hardware
> handled keys to F22 and F23, and software ones to F21. Patch is attached
> for that.
> 
> Questions, comments?

I still believe we need dedicated keycodes in kernel for that and make
sure that in-kernel maps use proper keycodes so that programs that do
not have the same limitations that X has could differentiate between
touchpad events and real F2* events. X can still continue to use f21, 22
and 23 (at least while it can't handle higher keycodes), and common
setups may rely on udev's facilities to remap the keys.

Thanks.

-- 
Dmitry

Re: Touchpad toggle mess

[Martin Pitt]

[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]

Hello Bastien,

Bastien Nocera [2010-11-05  0:00 +0000]:
> The patches in https://bugs.freedesktop.org/show_bug.cgi?id=31300
> implement this for the kernel, and for X.org.
> 
> Then we have the problem that udev's keymaps seem to use different
> function keys depending on the hardware [1], when X.org (because of the
> limitations of XKB) standardised on F22 for "XF86TouchpadToggle".

Thanks for bringing this up, indeed there's some cleanup in order
here.

> So we'll need to standardise on the keys used. I selected F21 for
> XF86TouchpadToggle, F22 for XF86TouchpadOn and F23 for XF86TouchpadOff.
> See the patch in:
> https://bugs.freedesktop.org/show_bug.cgi?id=31333
> 
> The remaining fixes would need to be in udev's keymaps, to set hardware
> handled keys to F22 and F23, and software ones to F21. Patch is attached
> for that.

Indeed the maps which don't currently use f22 should be fixed,
regardless of what happens in X/kernel/userspace. My main concern is
that F22 has acted as touchpad toggle key for years (many of those
were imported from hal-info originally), so if we change everything to
f21 now without updating userspace (things like gnome-settings-daemon)
in lockstep, then we break existing functionality. 

It would look slightly weird, but perhaps it might be better to keep
using F22 for toggling, and F1->on, F23->off?

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: Touchpad toggle mess

[Bastien Nocera]

On Thu, 2010-11-04 at 19:20 -0700, Dmitry Torokhov wrote:
> Hi Bastien,
> 
> On Fri, Nov 05, 2010 at 12:00:09AM +0000, Bastien Nocera wrote:
> > Heya,
> > 
> > In GNOME 2.32, we added support for touchpad toggle buttons, by
> > capturing the XF86TouchpadToggle button in gnome-settings-daemon,
> > showing a nice popup, and disabling the touchpad in software.
> > 
> > That works great for a number of laptops, but completely breaks a number
> > of others where the hardware handles the request, but still sends a key
> > event (usually separate ones for on and off). In those cases, we'd need
> > 2 more key types, in the kernel, and in X.org.
> 
> Rfkill story all over I guess ;(

Yes, though a fair bit simpler :)

> > The patches in https://bugs.freedesktop.org/show_bug.cgi?id=31300
> > implement this for the kernel, and for X.org.
> > 
> > Then we have the problem that udev's keymaps seem to use different
> > function keys depending on the hardware [1], when X.org (because of the
> > limitations of XKB) standardised on F22 for "XF86TouchpadToggle".
> > 
> > So we'll need to standardise on the keys used. I selected F21 for
> > XF86TouchpadToggle, F22 for XF86TouchpadOn and F23 for XF86TouchpadOff.
> > See the patch in:
> > https://bugs.freedesktop.org/show_bug.cgi?id=31333
> > 
> > The remaining fixes would need to be in udev's keymaps, to set hardware
> > handled keys to F22 and F23, and software ones to F21. Patch is attached
> > for that.
> > 
> > Questions, comments?
> 
> I still believe we need dedicated keycodes in kernel for that and make
> sure that in-kernel maps use proper keycodes so that programs that do
> not have the same limitations that X has could differentiate between
> touchpad events and real F2* events. X can still continue to use f21, 22
> and 23 (at least while it can't handle higher keycodes), and common
> setups may rely on udev's facilities to remap the keys.

I actually looked through the kernel, and couldn't find any drivers that
used F2X for touchpad toggling. All those keys are mapped in udev.

But I agree that we need to add those keys in the kernel, which is why I
cooked up:
https://bugs.freedesktop.org/attachment.cgi?id=39965

Do you want me to send the patch separately?

Cheers

Re: Touchpad toggle mess

[Bastien Nocera]

On Sat, 2010-11-06 at 11:30 -0400, Martin Pitt wrote:
> Hello Bastien,
> 
> Bastien Nocera [2010-11-05  0:00 +0000]:
> > The patches in https://bugs.freedesktop.org/show_bug.cgi?id=31300
> > implement this for the kernel, and for X.org.
> > 
> > Then we have the problem that udev's keymaps seem to use different
> > function keys depending on the hardware [1], when X.org (because of the
> > limitations of XKB) standardised on F22 for "XF86TouchpadToggle".
> 
> Thanks for bringing this up, indeed there's some cleanup in order
> here.
> 
> > So we'll need to standardise on the keys used. I selected F21 for
> > XF86TouchpadToggle, F22 for XF86TouchpadOn and F23 for XF86TouchpadOff.
> > See the patch in:
> > https://bugs.freedesktop.org/show_bug.cgi?id=31333
> > 
> > The remaining fixes would need to be in udev's keymaps, to set hardware
> > handled keys to F22 and F23, and software ones to F21. Patch is attached
> > for that.
> 
> Indeed the maps which don't currently use f22 should be fixed,
> regardless of what happens in X/kernel/userspace. My main concern is
> that F22 has acted as touchpad toggle key for years

No, for about a year:
http://cgit.freedesktop.org/xkeyboard-config/commit/?id=1d05eda8dfc706d6450cab5883120e0d5e1100c0

>  (many of those
> were imported from hal-info originally), so if we change everything to
> f21 now without updating userspace (things like gnome-settings-daemon)
> in lockstep, then we break existing functionality. 

You don't need to update gnome-settings-daemon. gnome-settings-daemon
doesn't see F21, F22 or F23, it'll see XF86TouchpadOn, etc.

> It would look slightly weird, but perhaps it might be better to keep
> using F22 for toggling, and F1->on, F23->off?

That sounds like a bit of a mess having those 2 keys not next to each.
F22 for toggling, F23 for on, F24 for off would do me fine, if that's
really required.

FWIW, the keys mapped in udev are the only ones that mapped F22. There's
nothing in the kernel using F22 for touchpad toggles of any kind.

Cheers

Re: Touchpad toggle mess

[Martin Pitt]

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

Hello Bastien,

Bastien Nocera [2010-11-06 15:58 +0000]:
> No, for about a year:
> http://cgit.freedesktop.org/xkeyboard-config/commit/?id=1d05eda8dfc706d6450cab5883120e0d5e1100c0

Ah, right, I missed that it didn't actually work all the way up to the
session, only at the evdev level.

> You don't need to update gnome-settings-daemon. gnome-settings-daemon
> doesn't see F21, F22 or F23, it'll see XF86TouchpadOn, etc.

Ah, ok.

So, that makes a lot of sense then, I committed your patch with a
little more verbiage in the changelog. It would be nice if we could
get the X.org counterpart in as well, so that the udev keymaps and
X.org don't run out of sync.

Thank you!

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: Touchpad toggle mess

[Bastien Nocera]

On Sat, 2010-11-06 at 12:33 -0400, Martin Pitt wrote:
> Hello Bastien,
> 
> Bastien Nocera [2010-11-06 15:58 +0000]:
> > No, for about a year:
> > http://cgit.freedesktop.org/xkeyboard-config/commit/?id=1d05eda8dfc706d6450cab5883120e0d5e1100c0
> 
> Ah, right, I missed that it didn't actually work all the way up to the
> session, only at the evdev level.
> 
> > You don't need to update gnome-settings-daemon. gnome-settings-daemon
> > doesn't see F21, F22 or F23, it'll see XF86TouchpadOn, etc.
> 
> Ah, ok.
> 
> So, that makes a lot of sense then, I committed your patch with a
> little more verbiage in the changelog. It would be nice if we could
> get the X.org counterpart in as well, so that the udev keymaps and
> X.org don't run out of sync.

We actually need 2 patches into X, one for adding the keysyms, one for
setting the keysyms to the Function keys.

Re: Touchpad toggle mess

[Julien Cristau]

On Sat, Nov  6, 2010 at 15:58:21 +0000, Bastien Nocera wrote:

> On Sat, 2010-11-06 at 11:30 -0400, Martin Pitt wrote:
> > Hello Bastien,
> > 
> > Bastien Nocera [2010-11-05  0:00 +0000]:
> > > The patches in https://bugs.freedesktop.org/show_bug.cgi?id=31300
> > > implement this for the kernel, and for X.org.
> > > 
> > > Then we have the problem that udev's keymaps seem to use different
> > > function keys depending on the hardware [1], when X.org (because of the
> > > limitations of XKB) standardised on F22 for "XF86TouchpadToggle".
> > 
> > Thanks for bringing this up, indeed there's some cleanup in order
> > here.
> > 
> > > So we'll need to standardise on the keys used. I selected F21 for
> > > XF86TouchpadToggle, F22 for XF86TouchpadOn and F23 for XF86TouchpadOff.
> > > See the patch in:
> > > https://bugs.freedesktop.org/show_bug.cgi?id=31333
> > > 
> > > The remaining fixes would need to be in udev's keymaps, to set hardware
> > > handled keys to F22 and F23, and software ones to F21. Patch is attached
> > > for that.
> > 
> > Indeed the maps which don't currently use f22 should be fixed,
> > regardless of what happens in X/kernel/userspace. My main concern is
> > that F22 has acted as touchpad toggle key for years
> 
> No, for about a year:
> http://cgit.freedesktop.org/xkeyboard-config/commit/?id=1d05eda8dfc706d6450cab5883120e0d5e1100c0
> 
That seems long enough that moving touchpad toggle from f22 to something
else for no particular reason will break stuff...

Cheers,
Julien
_______________________________________________
xorg@lists.freedesktop.org: X.Org support
Archives: http://lists.freedesktop.org/archives/xorg
Info: http://lists.freedesktop.org/mailman/listinfo/xorg
Your subscription address: gcfx-xorg-2@m.gmane.org