From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: Linux Input <linux-input@vger.kernel.org>,
Maxim Levitsky <maximlevitsky@gmail.com>
Subject: Re: [RFC/RFT] Reinject Alt+SysRq when no hotkeys have been pressed
Date: Wed, 10 Nov 2010 12:27:51 -0800 [thread overview]
Message-ID: <201011101227.51837.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <4CDAFCE0.60002@windriver.com>
On Wednesday, November 10, 2010 12:13:20 pm Jason Wessel wrote:
> On 11/09/2010 01:34 AM, Dmitry Torokhov wrote:
> > Now that KGDB knows how to release keys that have been pressed when
> > entering the debugger the only issue left is that SysRq handler is too
> > greedy and always swallows Alt+SysRq, causing print screen hotkey to
> > stop working. The solution is to re-inject the key combo when user
> > releases SysRq without pressing any other keys. The patch below does
> > just that and also releases keys that have been pressed before we enter
> > SysRq mode.
> >
> > Note that it depends on a patch to input core that will stop events
> > injected by one input handler from reaching the very same input handler
> > (attached).
> >
> > Comments/testing/suggestion are sought after.
>
> I applied both patches and tested all the known failures cases I had on
> my list and it looks good, for the non kdb cases.
>
> Tested-by: Jason Wessel <jason.wessel@windriver.com>
>
> However... I also tested this with the kdb keyboard release patchs plus
> your latest 2 patches we appear to have and incompatibility. The
> behavior is that when exiting kdb, the print screen trigger fires. I
> had not had a chance to debug it as of yet.
>
Hmm, let me think...
--
Dmitry
next prev parent reply other threads:[~2010-11-10 20:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 7:34 [RFC/RFT] Reinject Alt+SysRq when no hotkeys have been pressed Dmitry Torokhov
2010-11-10 20:13 ` Jason Wessel
2010-11-10 20:27 ` Dmitry Torokhov [this message]
2010-11-10 20:43 ` Jason Wessel
2010-11-11 1:42 ` Dmitry Torokhov
2010-11-11 8:55 ` Dmitry Torokhov
2010-11-11 14:35 ` Jason Wessel
2010-11-12 1:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011101227.51837.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=jason.wessel@windriver.com \
--cc=linux-input@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).