From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/2] sysfs: Introducing sysfs_create_bin_group() Date: Fri, 12 Nov 2010 11:38:17 -0800 Message-ID: <20101112193817.GA1299@core.coreip.homeip.net> References: <1289585918.2629.12.camel@neuromancer> <20101112192958.GA22233@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-yw0-f46.google.com ([209.85.213.46]:40951 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751920Ab0KLTi0 (ORCPT ); Fri, 12 Nov 2010 14:38:26 -0500 Content-Disposition: inline In-Reply-To: <20101112192958.GA22233@suse.de> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Greg KH Cc: Stefan Achatz , "Eric W. Biederman" , "Serge E. Hallyn" , Tejun Heo , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Thery On Fri, Nov 12, 2010 at 11:29:58AM -0800, Greg KH wrote: > On Fri, Nov 12, 2010 at 07:18:38PM +0100, Stefan Achatz wrote: > > Implemented group functions for easier creation of multiple binary sysfs > > attributes similar to existing attribute_group handling functions. > > The code reuses struct attribute_group instead of inventing a new struct > > binary_attribute_group. > > > > Signed-off-by: Stefan Achatz > > Looks good to me, nice job. > > Dmitry, do you want to take this through your tree as the mouse driver > change needs it? If so, feel free to do so and add a: > Acked-by: Greg Kroah-Hartman > > to the patch. > > If not, I'll be glad to take it, and the mouse driver change through my > tree if needed. > > Just let me know which is easier for you. > Actually the driver lives in hid so it's up to Jiri how he wants to handle this. Thanks. -- Dmitry