From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [RFC v1 PATCH 4/6] input: pmic8058_pwrkey: Add support for power key Date: Fri, 12 Nov 2010 11:58:16 -0800 Message-ID: <20101112195816.GC1299@core.coreip.homeip.net> References: <1289393281-4459-1-git-send-email-tsoni@codeaurora.org> <1289393281-4459-5-git-send-email-tsoni@codeaurora.org> <20101111072107.GA24415@core.coreip.homeip.net> <4CDBDAD5.90406@codeaurora.org> <20101112005741.GC17097@core.coreip.homeip.net> <4CDD013C.6050709@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-gx0-f174.google.com ([209.85.161.174]:47429 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756403Ab0KLT6Z (ORCPT ); Fri, 12 Nov 2010 14:58:25 -0500 Content-Disposition: inline In-Reply-To: <4CDD013C.6050709@codeaurora.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Trilok Soni Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, rtc-linux@googlegroups.com, linux-arm-msm@vger.kernel.org, wruan@codeaurora.org On Fri, Nov 12, 2010 at 02:26:28PM +0530, Trilok Soni wrote: > Hi Dmitry, > > On 11/12/2010 6:27 AM, Dmitry Torokhov wrote: > > On Thu, Nov 11, 2010 at 05:30:21PM +0530, Trilok Soni wrote: > >> Hi Dmitry, > >> > >> On 11/11/2010 12:51 PM, Dmitry Torokhov wrote: > >>> Hi Trilkok, > >>> > >>> On Wed, Nov 10, 2010 at 06:17:59PM +0530, Trilok Soni wrote: > >>>> Add support for PMIC8058 power key driven over dedicated KYPD_PWR_N > >>>> pin. It allows the user to specify the amount of time by which the > >>>> power key reporting can be delayed. > >>>> > >>> > >>> Why do we need to delay KEY_POWER reporting? Do we need to use high > >>> resolution timers or regular timers would do as well? KEY_END > >>> appears to be abused (you don't want to move your cursor to the end > >>> of line, do you?). Also I wonder if header file should reside in > >>> linux/mfd with the rest of pmic8058 components. > >> > >> Most of the time Mobile devices come with single physical key for > >> POWER, which if pressed for less than 500ms (configurable) then it > >> will only report KEY_END (which say locks the screen on mobile) and if > >> it pressed more than 500ms then it will also report KEY_POWER event > >> too, which will say display menu on your mobile for asking you to > >> suspend/switch off/etc, operations. > >> > > > > I see,. If you would have used KEY_SCREENLOCK iinstead of KEY_END I > > would likely not ask this question ;) > > > > KEY_SCRENNLOCK looks good, let me analyze the impact on userspace framework > which I have. I will come back on this in a day. > > >> For the timers I can move from hrtimers to regular timers. > >> > >> For the header file, I can move them to include/linux/mfd too. No > >> problem on that. > >> > > > > I am not even sure we need to keep them in separate header files, but it > > is up to you. > > Do you suggest that all the MFD sub-devices's platform data structures should come from single > header file? > It is an option, depends on how many external headers are needed, etc. When I looked at this particular file I got the feeling that it could be folded together with the rest. I expect that the board code that will specify platform resources will include every one of this sub-files anyway. But maybe if I was presented with the combined header I'd say "wow, thats too big"... Like I said, it is up to you. -- Dmitry