From: Chris Leech <christopher.leech@linux.intel.com>
To: linux-input@vger.kernel.org
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Subject: [PATCH 2/5] qt602240_ts: move clearing of pending interrupt closer to request_threaded_irq
Date: Tue, 16 Nov 2010 12:41:55 -0800 [thread overview]
Message-ID: <20101116204155.28796.6682.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20101116203914.28796.23141.stgit@localhost6.localdomain6>
I've seen interrupts asserted on the CHG pin between the call to make_highcgh()
during initialization and registering the interrupt handler, leaving CHG low
and no events get passed up.
This moves the clearing of pending messages to right before the call to
request_threaded_irq(). I still think there's a race here that could leave CHG
stuck low, but worry about clearing the message queue while the interrupt
handler is registered without some sort of additional locking.
Signed-off-by: Chris Leech <christopher.leech@linux.intel.com>
---
drivers/input/touchscreen/qt602240_ts.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/input/touchscreen/qt602240_ts.c b/drivers/input/touchscreen/qt602240_ts.c
index 0b92c9d..95496ec 100644
--- a/drivers/input/touchscreen/qt602240_ts.c
+++ b/drivers/input/touchscreen/qt602240_ts.c
@@ -991,10 +991,6 @@ static int qt602240_initialize(struct qt602240_data *data)
if (error)
return error;
- error = qt602240_make_highchg(data);
- if (error)
- return error;
-
qt602240_handle_pdata(data);
/* Backup to memory */
@@ -1280,6 +1276,10 @@ static int __devinit qt602240_probe(struct i2c_client *client,
if (error)
goto err_free_object;
+ error = qt602240_make_highchg(data);
+ if (error)
+ goto err_free_object;
+
error = request_threaded_irq(client->irq, NULL, qt602240_interrupt,
IRQF_TRIGGER_FALLING, client->dev.driver->name, data);
if (error) {
next prev parent reply other threads:[~2010-11-16 20:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 20:41 [PATCH 0/4] qt602240_ts changes for Intel mid platform Chris Leech
2010-11-16 20:41 ` [PATCH 1/5] qt602240_ts: fix wrong sizeof in object table allocation Chris Leech
2010-11-18 11:16 ` Joonyoung Shim
2010-11-18 11:30 ` Joonyoung Shim
2010-11-16 20:41 ` Chris Leech [this message]
2010-11-18 12:53 ` [PATCH 2/5] qt602240_ts: move clearing of pending interrupt closer to request_threaded_irq Joonyoung Shim
2010-11-18 19:29 ` Chris Leech
2010-11-18 22:54 ` Dmitry Torokhov
2010-11-16 20:42 ` [PATCH 3/5] qt602240_ts: Trust factory configuration of touchscreen Chris Leech
2010-11-18 13:09 ` Joonyoung Shim
2010-11-18 19:41 ` Chris Leech
2010-11-16 20:42 ` [PATCH 4/5] qt602240_ts: add optional hooks for board specific reset logic Chris Leech
2010-11-18 11:32 ` Joonyoung Shim
2010-11-18 19:46 ` Chris Leech
2010-11-16 20:42 ` [PATCH 5/5] qt602240_ts: add mXT224 identifier to id_table, to match Intel mid firmware identifier Chris Leech
2010-11-18 11:34 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116204155.28796.6682.stgit@localhost6.localdomain6 \
--to=christopher.leech@linux.intel.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).