From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org, Vojtech Pavlik <vojtech@ucw.cz>
Subject: Re: [RFC][PATCH] Input: ct82c710 - remove a redundant serio_register_port()
Date: Sun, 21 Nov 2010 22:24:21 -0800 [thread overview]
Message-ID: <20101122062421.GA31175@core.coreip.homeip.net> (raw)
In-Reply-To: <1290406007.6941.15.camel@mola>
On Mon, Nov 22, 2010 at 02:06:47PM +0800, Axel Lin wrote:
> We already call serio_register_port() in ct82c710_probe(),
> thus remove a redundant serio_register_port() in ct82c710_init().
>
> Looks like this bug is introduced by
> 916d83cfe5da1cda454d8b0ae233f06b58bd7f91
> "Input: ct82c710 - convert to the new platform device interface"
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> I don't have this hardware handy, I appreciate if someone can test this patch.
>
I doubt anyone has; maybe I should start pruning older drivers...
BTW, the fix is obviously correct so I'll apply it and your other two
patches as well. Thanks Axel.
--
Dmitry
prev parent reply other threads:[~2010-11-22 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 6:06 [RFC][PATCH] Input: ct82c710 - remove a redundant serio_register_port() Axel Lin
2010-11-22 6:24 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122062421.GA31175@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=axel.lin@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).