From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: turbografx - fix reference counting
Date: Wed, 1 Dec 2010 09:20:59 -0800 [thread overview]
Message-ID: <20101201172059.GC11196@core.coreip.homeip.net> (raw)
In-Reply-To: <1291208701-3016-1-git-send-email-namhyung@gmail.com>
On Wed, Dec 01, 2010 at 10:05:01PM +0900, Namhyung Kim wrote:
> The ref-count of parport gained from parport_find_number()
> was not released in normal path.
>
Applied, thanks.
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
> drivers/input/joystick/turbografx.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/joystick/turbografx.c b/drivers/input/joystick/turbografx.c
> index d53b9e9..27b6a3c 100644
> --- a/drivers/input/joystick/turbografx.c
> +++ b/drivers/input/joystick/turbografx.c
> @@ -245,6 +245,7 @@ static struct tgfx __init *tgfx_probe(int parport, int *n_buttons, int n_devs)
> goto err_free_tgfx;
> }
>
> + parport_put_port(pp);
> return tgfx;
>
> err_free_dev:
> --
> 1.7.0.4
>
--
Dmitry
prev parent reply other threads:[~2010-12-01 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 13:05 [PATCH] Input: turbografx - fix reference counting Namhyung Kim
2010-12-01 17:20 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201172059.GC11196@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).