From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ping Cheng <pinglinux@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2]input - wacom_w8001: Add one finger touch support
Date: Thu, 9 Dec 2010 10:02:32 -0800 [thread overview]
Message-ID: <201012091002.33372.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <AANLkTinMKDjT9eTJkvvstYG_7LSs7mhcPCRrMsQAANhh@mail.gmail.com>
On Thursday, December 09, 2010 09:39:09 am Ping Cheng wrote:
> On Wed, Dec 8, 2010 at 10:44 PM, Dmitry Torokhov
>
> <dmitry.torokhov@gmail.com> wrote:
> > On Wed, Dec 08, 2010 at 05:23:49PM -0800, Ping Cheng wrote:
> >> Signed-off-by: Ping Cheng <pingc@wacom.com>
> >> ---
> >> drivers/input/touchscreen/wacom_w8001.c | 74
> >> +++++++++++++++++++++++++++++-- 1 files changed, 70 insertions(+), 4
> >> deletions(-)
> >>
> >> diff --git a/drivers/input/touchscreen/wacom_w8001.c
> >> b/drivers/input/touchscreen/wacom_w8001.c index 90b92e8..68087d8 100644
> >> --- a/drivers/input/touchscreen/wacom_w8001.c
> >> +++ b/drivers/input/touchscreen/wacom_w8001.c
> >> @@ -3,6 +3,7 @@
> >> *
> >> * Copyright (c) 2008 Jaya Kumar
> >> * Copyright (c) 2010 Red Hat, Inc.
> >> + * Copyright (c) 2010 Ping Cheng, Wacom. <pingc@wacom.com>
> >> *
> >> * This file is subject to the terms and conditions of the GNU General
> >> Public * License. See the file COPYING in the main directory of this
> >> archive for @@ -86,6 +87,12 @@ struct w8001 {
> >> char phys[32];
> >> int type;
> >> unsigned int pktlen;
> >> + bool pen_in_prox;
> >> + bool has_touch;
> >> + int max_touch_x;
> >> + int max_touch_y;
> >> + int max_pen_x;
> >> + int max_pen_y;
> >
> > This does not apply to my tree. What tree was it made against?
>
> It was based on Henrik's mt-next branch since there are MT support in
> the driver. Should I use yours for v2?
Now that I have merged Henrik's it should not matter but generally it would
be helpful to specify which tree the patch was made against (if not mine)
so I can plan the merging accordingly.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-12-09 18:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 1:23 [PATCH 2/2]input - wacom_w8001: Add one finger touch support Ping Cheng
2010-12-09 6:44 ` Dmitry Torokhov
2010-12-09 17:39 ` Ping Cheng
2010-12-09 18:02 ` Dmitry Torokhov [this message]
2010-12-09 15:06 ` Chris Bagwell
2010-12-09 19:36 ` Ping Cheng
2010-12-09 19:50 ` Dmitry Torokhov
2010-12-09 21:21 ` Chris Bagwell
2010-12-10 1:29 ` Ping Cheng
2010-12-10 13:39 ` Chris Bagwell
2010-12-10 7:38 ` Dmitry Torokhov
2010-12-10 13:47 ` Chris Bagwell
2010-12-10 17:37 ` Ping Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012091002.33372.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).