From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: mt: Interface and MT_TOOL documentation updates
Date: Thu, 9 Dec 2010 23:43:51 -0800 [thread overview]
Message-ID: <20101210074351.GC21009@core.coreip.homeip.net> (raw)
In-Reply-To: <1291929732-5989-1-git-send-email-rydberg@euromail.se>
On Thu, Dec 09, 2010 at 10:22:12PM +0100, Henrik Rydberg wrote:
> The recent input-mt interface changes together with
> recent discussions about pen and touch and support
> for legacy multitouch pads suggest that the documentation
> on MT tool types be expanded. This patch adds references
> to the new interface, and adds a section for MT_TOOL types,
> in particular documenting the use of MT_TOOL_ENVELOPE.
>
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
The explanation of the new types makes sense to me... Do you think we
could add some comments directly to input.h?
> @@ -247,21 +249,34 @@ ABS_MT_TOOL_TYPE
> The type of approaching tool. A lot of kernel drivers cannot distinguish
> between different tool types, such as a finger or a pen. In such cases, the
> event should be omitted. The protocol currently supports MT_TOOL_FINGER and
s/and/,/
> -MT_TOOL_PEN and MT_TOOL_ENVELOPE [2].
> +MT_TOOL_PEN and MT_TOOL_ENVELOPE [2]. For type B devices, this event is
> +handled by input core, via the input_mt interface.
> +
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-12-10 7:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 21:22 [PATCH] input: mt: Interface and MT_TOOL documentation updates Henrik Rydberg
2010-12-10 7:43 ` Dmitry Torokhov [this message]
2010-12-10 13:54 ` Henrik Rydberg
2010-12-10 17:55 ` Ping Cheng
2010-12-10 18:13 ` Henrik Rydberg
2010-12-10 18:52 ` Dmitry Torokhov
2010-12-10 19:00 ` Ping Cheng
2010-12-10 20:01 ` Henrik Rydberg
2010-12-10 21:17 ` Ping Cheng
2010-12-10 18:13 ` Dmitry Torokhov
2010-12-10 18:50 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210074351.GC21009@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).