linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Add support for Wacom Bamboo Pen (CTL460, Product ID 0xD4).
@ 2010-12-11  2:10 kevin.granade@gmail.com
  2010-12-11  2:36 ` Ping Cheng
  0 siblings, 1 reply; 3+ messages in thread
From: kevin.granade@gmail.com @ 2010-12-11  2:10 UTC (permalink / raw)
  To: linux-input; +Cc: dmitry.torokhov, chris, pingc

Add the features struct and device table entry to enable the Wacom Bamboo 
Pen.

Generated against input/for-linus since that seems to be the most recent 
input branch.

Signed-off-by: Kevin Granade <kevin.granade@gmail.com>
---
 drivers/input/tablet/wacom_wac.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index 4852b44..435b0af 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -1436,6 +1436,8 @@ static struct wacom_features wacom_features_0xD2 =
 	{ "Wacom Bamboo Craft",   WACOM_PKGLEN_BBFUN,     14720,  9200, 1023, 63, BAMBOO_PT };
 static struct wacom_features wacom_features_0xD3 =
 	{ "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13530, 1023, 63, BAMBOO_PT };
+static const struct wacom_features wacom_features_0xD4 =
+	{ "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     14720,  9200,  255, 63, BAMBOO_PT };
 static struct wacom_features wacom_features_0xD8 =
 	{ "Wacom Bamboo Comic 2FG", WACOM_PKGLEN_BBFUN,   21648, 13530, 1023, 63, BAMBOO_PT };
 static struct wacom_features wacom_features_0xDA =
@@ -1510,6 +1512,7 @@ const struct usb_device_id wacom_ids[] = {
 	{ USB_DEVICE_WACOM(0xD1) },
 	{ USB_DEVICE_WACOM(0xD2) },
 	{ USB_DEVICE_WACOM(0xD3) },
+	{ USB_DEVICE_WACOM(0xD4) },
 	{ USB_DEVICE_WACOM(0xD8) },
 	{ USB_DEVICE_WACOM(0xDA) },
 	{ USB_DEVICE_WACOM(0xDB) },
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Add support for Wacom Bamboo Pen (CTL460, Product ID 0xD4).
  2010-12-11  2:10 [PATCH] Add support for Wacom Bamboo Pen (CTL460, Product ID 0xD4) kevin.granade@gmail.com
@ 2010-12-11  2:36 ` Ping Cheng
  2010-12-11  7:03   ` Dmitry Torokhov
  0 siblings, 1 reply; 3+ messages in thread
From: Ping Cheng @ 2010-12-11  2:36 UTC (permalink / raw)
  To: kevin.granade@gmail.com; +Cc: linux-input, dmitry.torokhov, chris, pingc

On Fri, Dec 10, 2010 at 6:10 PM, kevin.granade@gmail.com
<azmodean@gmail.com> wrote:
> Add the features struct and device table entry to enable the Wacom Bamboo
> Pen.
>
> Generated against input/for-linus since that seems to be the most recent
> input branch.
>
> Signed-off-by: Kevin Granade <kevin.granade@gmail.com>

Acked-by: Ping Cheng <pingc@wacom.com>

Ping

> ---
>  drivers/input/tablet/wacom_wac.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
> index 4852b44..435b0af 100644
> --- a/drivers/input/tablet/wacom_wac.c
> +++ b/drivers/input/tablet/wacom_wac.c
> @@ -1436,6 +1436,8 @@ static struct wacom_features wacom_features_0xD2 =
>        { "Wacom Bamboo Craft",   WACOM_PKGLEN_BBFUN,     14720,  9200, 1023, 63, BAMBOO_PT };
>  static struct wacom_features wacom_features_0xD3 =
>        { "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13530, 1023, 63, BAMBOO_PT };
> +static const struct wacom_features wacom_features_0xD4 =
> +       { "Wacom Bamboo Pen",     WACOM_PKGLEN_BBFUN,     14720,  9200,  255, 63, BAMBOO_PT };
>  static struct wacom_features wacom_features_0xD8 =
>        { "Wacom Bamboo Comic 2FG", WACOM_PKGLEN_BBFUN,   21648, 13530, 1023, 63, BAMBOO_PT };
>  static struct wacom_features wacom_features_0xDA =
> @@ -1510,6 +1512,7 @@ const struct usb_device_id wacom_ids[] = {
>        { USB_DEVICE_WACOM(0xD1) },
>        { USB_DEVICE_WACOM(0xD2) },
>        { USB_DEVICE_WACOM(0xD3) },
> +       { USB_DEVICE_WACOM(0xD4) },
>        { USB_DEVICE_WACOM(0xD8) },
>        { USB_DEVICE_WACOM(0xDA) },
>        { USB_DEVICE_WACOM(0xDB) },
> --
> 1.5.6.5
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Add support for Wacom Bamboo Pen (CTL460, Product ID 0xD4).
  2010-12-11  2:36 ` Ping Cheng
@ 2010-12-11  7:03   ` Dmitry Torokhov
  0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2010-12-11  7:03 UTC (permalink / raw)
  To: Ping Cheng; +Cc: kevin.granade@gmail.com, linux-input, chris, pingc

On Fri, Dec 10, 2010 at 06:36:12PM -0800, Ping Cheng wrote:
> On Fri, Dec 10, 2010 at 6:10 PM, kevin.granade@gmail.com
> <azmodean@gmail.com> wrote:
> > Add the features struct and device table entry to enable the Wacom Bamboo
> > Pen.
> >
> > Generated against input/for-linus since that seems to be the most recent
> > input branch.
> >
> > Signed-off-by: Kevin Granade <kevin.granade@gmail.com>
> 
> Acked-by: Ping Cheng <pingc@wacom.com>
> 

Applied, thanks Kevin.

Ping, I wonder if you could gather the list of device IDs that Wacom
produced and we support and send it to me as one patch instead of having
users add them one by one?

Thanks.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-12-11  7:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-11  2:10 [PATCH] Add support for Wacom Bamboo Pen (CTL460, Product ID 0xD4) kevin.granade@gmail.com
2010-12-11  2:36 ` Ping Cheng
2010-12-11  7:03   ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).