[PATCH v2 2/2] input: keyboard: MCS5080: support shutdown.

[PATCH v2 2/2] input: keyboard: MCS5080: support shutdown.

[Kim, HeungJun]

This patch supports shutdown functions for mcs5080 touchkey
driver.

Signed-off-by: Heungjun Kim <riverful.kim@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/input/keyboard/mcs_touchkey.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/input/keyboard/mcs_touchkey.c b/drivers/input/keyboard/mcs_touchkey.c
index 92149e4..e842ebb 100644
--- a/drivers/input/keyboard/mcs_touchkey.c
+++ b/drivers/input/keyboard/mcs_touchkey.c
@@ -212,6 +212,14 @@ static int __devexit mcs_touchkey_remove(struct i2c_client *client)
 	return 0;
 }
 
+static void mcs_touchkey_shutdown(struct i2c_client *client)
+{
+	struct mcs_touchkey_data *data = i2c_get_clientdata(client);
+
+	if (data->poweron)
+		data->poweron(0);
+}
+
 #ifdef CONFIG_PM
 static int mcs_touchkey_suspend(struct device *dev)
 {
@@ -267,6 +275,7 @@ static struct i2c_driver mcs_touchkey_driver = {
 	},
 	.probe		= mcs_touchkey_probe,
 	.remove		= __devexit_p(mcs_touchkey_remove),
+	.shutdown       = mcs_touchkey_shutdown,
 	.id_table	= mcs_touchkey_id,
 };
 
-- 
1.7.0.4

Re: [PATCH v2 2/2] input: keyboard: MCS5080: support shutdown.

[Dmitry Torokhov]

On Fri, Nov 19, 2010 at 03:23:09PM +0900, Kim, HeungJun wrote:
> This patch supports shutdown functions for mcs5080 touchkey
> driver.
> 

Rarely a device needs shutdown method; normally it is enough to simply
cut power off. Why this device needs it?

Thanks.

-- 
Dmitry

Re: [PATCH v2 2/2] input: keyboard: MCS5080: support shutdown.

[Kim, HeungJun]

And the reason to insert powerof() function is that,
the MCS50XX series has some HW bugs like following:

If the MCS50XX is not yet powered down before the whole system is power-down,
when control pins like a powerup or interrupt is pulluped,
the residue current is flow into chips and the chip still consume the power.

It seems not be important general PC(if this small device is implemented with PC),
but it's very important in the mobile device.

sorry not to write such specific contents before.

Thanks.

Regards,
HeungJun Kim


2010-12-13 오후 6:01, Dmitry Torokhov 쓴 글:
> On Fri, Nov 19, 2010 at 03:23:09PM +0900, Kim, HeungJun wrote:
>> This patch supports shutdown functions for mcs5080 touchkey
>> driver.
>>
> 
> Rarely a device needs shutdown method; normally it is enough to simply
> cut power off. Why this device needs it?
> 
> Thanks.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html