* Re:[v1] input/tc3589x: add tc3589x keypad support
@ 2010-12-14 5:31 Sundar R IYER
2010-12-14 18:46 ` [v1] " Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Sundar R IYER @ 2010-12-14 5:31 UTC (permalink / raw)
To: dmitry.torokhov@gmail.com; +Cc: linux-input@vger.kernel.org
Hi Dmitry,
>I do not see where you'd enable the keypad. What will happen if you
>unbind/unload the driver (which will cause explicit call to disable) and
>then try loading the module again?
A minor doubt: I enable the keypad in the open call; leaving it to the user
space to control the input device. If I understand your question, then I
should not be disabling the keypad in the tc3589x_keypad_remove, which
might cause conflicts. Is my understanding correct?
Cheers!
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [v1] input/tc3589x: add tc3589x keypad support
2010-12-14 5:31 Re:[v1] input/tc3589x: add tc3589x keypad support Sundar R IYER
@ 2010-12-14 18:46 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2010-12-14 18:46 UTC (permalink / raw)
To: Sundar R IYER; +Cc: linux-input@vger.kernel.org
On Tue, Dec 14, 2010 at 06:31:20AM +0100, Sundar R IYER wrote:
> Hi Dmitry,
>
> >I do not see where you'd enable the keypad. What will happen if you
> >unbind/unload the driver (which will cause explicit call to disable) and
> >then try loading the module again?
>
> A minor doubt: I enable the keypad in the open call; leaving it to the user
> space to control the input device. If I understand your question, then I
> should not be disabling the keypad in the tc3589x_keypad_remove, which
> might cause conflicts. Is my understanding correct?
Ah, I missed the fact that you have open and close. I think the best way
would be to serialize open/close/suspend/resume (you can use dev->mutex)
in suspend/resume and track device state so that you:
1. On resume do not enable the device if it hasn't been opened.
2. Can remove disable in remove().
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-14 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-14 5:31 Re:[v1] input/tc3589x: add tc3589x keypad support Sundar R IYER
2010-12-14 18:46 ` [v1] " Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).