From: Tony Lindgren <tony@atomide.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: linux-omap@vger.kernel.org, linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Keyboard: omap-keypad: use matrix_keypad.h
Date: Fri, 17 Dec 2010 19:10:04 -0800 [thread overview]
Message-ID: <20101218031003.GP5941@atomide.com> (raw)
In-Reply-To: <201012172332.06480.jkrzyszt@tis.icnet.pl>
* Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [101217 14:33]:
> Most keypad drivers make use of the <linux/input/matrix_keypad.h>
> defined macros, structures and inline functions.
>
> Convert omap-keypad driver to use those as well, as suggested by a
> compile time warning, hardcoded into the OMAP <palt/keypad.h>.
>
> Created against linux-2.6.37-rc5.
> Tested on Amstrad Delta.
> Compile tested with omap1_defconfig and omap2plus_defconfig shrinked to
> board-h4.
Great, good to get rid of those annoying warnings!
> drivers/input/keyboard/omap-keypad.c | 36 ++++----
> include/linux/input/matrix_keypad.h | 2
We also need Dmitry's ack for these changes.
Regards,
Tony
next prev parent reply other threads:[~2010-12-18 3:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 22:32 [PATCH] Keyboard: omap-keypad: use matrix_keypad.h Janusz Krzysztofik
2010-12-18 3:10 ` Tony Lindgren [this message]
2010-12-18 4:29 ` Cory Maccarrone
2010-12-18 5:29 ` Cory Maccarrone
2010-12-18 5:38 ` Cory Maccarrone
2010-12-18 6:01 ` Dmitry Torokhov
2010-12-18 11:31 ` Janusz Krzysztofik
2010-12-18 15:39 ` [PATCH v2] " Janusz Krzysztofik
2010-12-20 15:29 ` Aaro Koskinen
2010-12-20 17:32 ` Janusz Krzysztofik
2010-12-20 18:02 ` Dmitry Torokhov
2010-12-20 18:49 ` Janusz Krzysztofik
2010-12-20 19:03 ` aaro.koskinen
2010-12-20 20:21 ` Janusz Krzysztofik
2010-12-20 21:09 ` [PATCH v3] " Janusz Krzysztofik
2010-12-21 11:20 ` Aaro Koskinen
2010-12-22 10:16 ` Dmitry Torokhov
2010-12-22 19:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101218031003.GP5941@atomide.com \
--to=tony@atomide.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).