From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH] Input: Fix double equality sign in uevent
Date: Sun, 19 Dec 2010 00:04:28 -0800 [thread overview]
Message-ID: <20101219080427.GA10074@core.coreip.homeip.net> (raw)
In-Reply-To: <1292700717-1610-1-git-send-email-rydberg@euromail.se>
On Sat, Dec 18, 2010 at 08:31:57PM +0100, Henrik Rydberg wrote:
> Looking at the uevent stream for input devices, all properties
> are on the form "A=B" except the bitmap values, which are on the
> form "A==B". Remedied with this patch.
>
> Cc: stable@kernel.org
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> ---
> Hi Dmitry,
>
> Unless the input bitmap properties should really behave differently,
> this patch ought to be a candidate for 2.6.37.
>
Hmm, I do not think so because:
- either nobody uses bitmap variables and then it is not priority
- users worked around the problem and by applying fix we'd be
breaking their setups.
I think we should apply it but at the beginning of .38 cycle to give us
a chance to evaluate and maybe revert.
Does this make sense?
--
Dmitry
next prev parent reply other threads:[~2010-12-19 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-18 19:31 [PATCH] Input: Fix double equality sign in uevent Henrik Rydberg
2010-12-19 8:04 ` Dmitry Torokhov [this message]
2010-12-19 8:37 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101219080427.GA10074@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).