From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
Cc: dmitry.torokhov@gmail.com, corentin.chary@gmail.com,
corentincj@iksaif.net, tiwai@novell.com,
carlos@strangeworlds.co.uk, jbenc@suse.cz, jdelvare@suse.de,
trenn@suse.de, linux-input@vger.kernel.org,
platform-driver-x86@vger.kernel.org, "Lee,
Chun-Yi" <jlee@novell.com>
Subject: Re: [PATCH 2/4] acer-wmi: Enabled Acer Launch Manager mode
Date: Mon, 20 Dec 2010 16:06:12 +0000 [thread overview]
Message-ID: <20101220160612.GA25502@srcf.ucam.org> (raw)
In-Reply-To: <1291688963-23232-3-git-send-email-jlee@novell.com>
On Tue, Dec 07, 2010 at 10:29:21AM +0800, Lee, Chun-Yi wrote:
> + struct lm_return_value return_value;
> + acpi_status status;
> + struct lm_input_params params = {
> + .function_num = 0x1,
> + .commun_devices = 0x0041, /* WiFi on, 3G on, BT off */
Why this set of devices?
> + printk(ACER_INFO "Enabled Launch Manager");
This is the default behaviour, so I don't think you need to print
anything in this case.
The other patches in the series look fine - I'll apply those to -next
now.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-12-20 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 2:29 [PATCH 0/4] acer-wmi: Add new wmi support to acer-wmi driver Lee, Chun-Yi
2010-12-07 2:29 ` [PATCH 1/4] acer-wmi: Add acer wmi hotkey events support Lee, Chun-Yi
2010-12-07 2:29 ` [PATCH 2/4] acer-wmi: Enabled Acer Launch Manager mode Lee, Chun-Yi
2010-12-07 2:29 ` [PATCH 3/4] acer-wmi: Add 3G rfkill sysfs file Lee, Chun-Yi
2010-12-07 2:29 ` [PATCH 4/4] acer-wmi: Detect the WiFi/Bluetooth/3G devices available Lee, Chun-Yi
2010-12-20 16:06 ` Matthew Garrett [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-21 3:30 [PATCH 2/4] acer-wmi: Enabled Acer Launch Manager mode Joey Lee
2011-01-07 22:27 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220160612.GA25502@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=carlos@strangeworlds.co.uk \
--cc=corentin.chary@gmail.com \
--cc=corentincj@iksaif.net \
--cc=dmitry.torokhov@gmail.com \
--cc=jbenc@suse.cz \
--cc=jdelvare@suse.de \
--cc=jlee@novell.com \
--cc=joeyli.kernel@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiwai@novell.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).