Re: [PATCH] Add support for the built-in digitizer in the Lenovo W700

Re: [PATCH] Add support for the built-in digitizer in the Lenovo W700

[Ajay Ramaswamy]

[-- Attachment #1: Type: text/plain, Size: 4653 bytes --]

Ping

Thank you for your support and encouragement, I have followed your
instructions and made a git patch for the kernel

I have not added any Acked-by line for this patch, I think you need to
do that? Please do the needful.


Thanks & best regards

Ajay

On Mon, Dec 20, 2010 at 10:10 AM, Ping Cheng <pinglinux@gmail.com> wrote:
> On Sun, Dec 19, 2010 at 1:26 AM, Ajay Ramaswamy
> <linuxwacom@ramaswamy.net> wrote:
>> Ping
>>
>> Thanks for your support in getting this done. I have made a patch
>> against xf86-input-wacom master in git for Peter.
>
> The patch looks good to me. I thought it would take sometime for you
> to make a git patch since you mentioned that you have not programmed
> in C for 20 years.
>
> With your prompt reply, I think you can make a kernel patch just fine.
> Please make your kernel patch based on the next branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git and
> submit it to linux-input@vger.kernel.org,
>
> Thank you.
>
> Ping
>
>> Hopefully all this will result in fedora 15 having support for my laptop.
>>
>> Thanks & best regards
>>
>> Ajay
>>
>> On Sun, Dec 19, 2010 at 6:19 AM, Ping Cheng <pinglinux@gmail.com> wrote:
>>> On Thu, Dec 16, 2010 at 6:37 AM, Ajay Ramaswamy <ajayr@krithika.net> wrote:
>>>> Hello Ping Cheng
>>>>
>>>> I have been using the tablet for the last 4 months without any
>>>> problems, Today I have updated my patches against the current
>>>> development series 0.10.10, can you accept these patches now?
>>>
>>> The xf86-input-wacom looks fine. If you don't mind, please make a
>>> patch in git format with my Acked-by tag so Peter can merge it to the
>>> git repo.
>>>
>>> I'll make a git patch based on your input-wacom-thinkpad-w700.patch
>>> and submit it to linux-input on your behalf.
>>>
>>> Thank you.
>>>
>>> Ping
>>>
>>>> My request for testing has not got any response so far! Perhaps the
>>>> laptop is too exotic for it to be used widely by Linux users.
>>>>
>>>> http://forums.lenovo.com/t5/W-Series-ThinkPad-Laptops/HELP-W700-color-calibration-or-finger-print-reader-and-tablet-in/m-p/211014#M7584
>>>>
>>>> and
>>>>
>>>> http://forum.thinkpads.com/viewtopic.php?f=48&t=89292&hilit=w700+wacom+linux
>>>>
>>>> and
>>>>
>>>> http://forums.fedoraforum.org/showthread.php?t=249263&highlight=w700+wacom
>>>>
>>>>
>>>> Thanks for your consideration.
>>>>
>>>> with best regards
>>>> Ajay
>>>>
>>>> On Tue, Jul 27, 2010 at 10:49 PM, Ping Cheng <pinglinux@gmail.com> wrote:
>>>>> On Tue, Jul 27, 2010 at 5:22 AM, Ajay Ramaswamy <ajayr@krithika.net> wrote:
>>>>>> On Tuesday 27 Jul 2010 12:03:38 pm Ping Cheng wrote:
>>>>>>
>>>>>>> >> I do have one question though: did you add LENOVO_VENDOR_ID and 0x6004
>>>>>>> >> to the ignore list of hid-core.c in your kernel source?
>>>>>>> >
>>>>>>> > NO, should I do that?
>>>>>>>
>>>>>>> Oh, weird. If you didn't add it to the ignore list, it should be
>>>>>>> grabbed by HID. That is Wacom driver can not take control of it. Maybe
>>>>>>> the structure has been changed for your kernel version?
>>>>>>>
>>>>>>> > Like I said I haven't programmed in C for 20 years so
>>>>>>> > most of this is shooting in the dark.
>>>>>>> >
>>>>>>> > I have also registered in a couple of Thinkpad forums and made a request
>>>>>>> > for testing of these patches, let us see if there is any response.
>>>>>>>
>>>>>>> Good idea. I'll wait for the feedback.
>>>>>>>
>>>>>>> Thank you.
>>>>>>>
>>>>>>> Ping
>>>>>>
>>>>>>
>>>>>> [ajayr@kate by-id]$ ls -l /dev/input/by-id
>>>>>> total 0
>>>>>> lrwxrwxrwx 1 root root 9 Jul 27 17:22 usb-Chicony_Electronics_Co.__Ltd._480c-
>>>>>> event-if00 -> ../event9
>>>>>> lrwxrwxrwx 1 root root 9 Jul 27 17:22 usb-Logitech_USB_Gaming_Mouse-event-
>>>>>> mouse -> ../event5
>>>>>> lrwxrwxrwx 1 root root 9 Jul 27 17:22 usb-Logitech_USB_Gaming_Mouse-mouse ->
>>>>>> ../mouse1
>>>>>> lrwxrwxrwx 1 root root 9 Jul 27 17:22 usb-Tablet_ISD-V4-event-mouse ->
>>>>>> ../event6
>>>>>> lrwxrwxrwx 1 root root 9 Jul 27 17:22 usb-Tablet_ISD-V4-mouse -> ../mouse2
>>>>>> [ajayr@kate by-id]$
>>>>>>
>>>>>>
>>>>>> is this expected? should the tablet show both as mouse and event?
>>>>>
>>>>> Those are fine.
>>>>>
>>>>>> shall I rebuild a kernel with a patch to ignore the LENOVO 0x6004 device like this?
>>>>>
>>>>> Since the tablet works for you, I would think you don't need the
>>>>> change. However, I would also eager to know if there would be any
>>>>> difference in the behaviour of the tablet if you apply the patch.
>>>>> Please make sure you are adding the line to ignorelist instead of
>>>>> blacklist (I do not have the source to diff it).
>>>>>
>>>>> Thank you.
>>>>>
>>>>> Ping
>>>>>
>>>>
>>>
>>
>

[-- Attachment #2: 0001-Add-support-for-the-built-in-digitizer-in-the-Lenovo.patch --]
[-- Type: text/x-patch, Size: 2077 bytes --]

From 8565e03c5995944d628fd1f8041ff00313600fa7 Mon Sep 17 00:00:00 2001
From: Ajay Ramaswamy <ajay@ramaswamy.net>
Date: Mon, 20 Dec 2010 14:14:23 +0530
Subject: [PATCH] Add support for the built-in digitizer in the Lenovo W700

Submitted-by: Ajay Ramaswamy <ajay@ramaswamy.net>
---
 drivers/input/tablet/wacom.h     |    1 +
 drivers/input/tablet/wacom_wac.c |    7 +++++++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/input/tablet/wacom.h b/drivers/input/tablet/wacom.h
index de5adb1..23317bd 100644
--- a/drivers/input/tablet/wacom.h
+++ b/drivers/input/tablet/wacom.h
@@ -103,6 +103,7 @@ MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE(DRIVER_LICENSE);
 
 #define USB_VENDOR_ID_WACOM	0x056a
+#define USB_VENDOR_ID_LENOVO	0x17ef
 
 struct wacom {
 	dma_addr_t data_dma;
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index 0b05254..0024d3e 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -1424,11 +1424,17 @@ static struct wacom_features wacom_features_0xD2 =
 	{ "Wacom Bamboo Craft",   WACOM_PKGLEN_BBFUN,     14720,  9200, 1023, 63, BAMBOO_PT };
 static struct wacom_features wacom_features_0xD3 =
 	{ "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13530, 1023, 63, BAMBOO_PT };
+static const struct wacom_features wacom_features_0x6004 =
+	{ "ISD-V4",               WACOM_PKGLEN_GRAPHIRE,  12800, 8000, 255, 0, TABLETPC };
 
 #define USB_DEVICE_WACOM(prod)					\
 	USB_DEVICE(USB_VENDOR_ID_WACOM, prod),			\
 	.driver_info = (kernel_ulong_t)&wacom_features_##prod
 
+#define USB_DEVICE_LENOVO(prod)					\
+	USB_DEVICE(USB_VENDOR_ID_LENOVO, prod),			\
+	.driver_info = (kernel_ulong_t)&wacom_features_##prod
+
 const struct usb_device_id wacom_ids[] = {
 	{ USB_DEVICE_WACOM(0x00) },
 	{ USB_DEVICE_WACOM(0x10) },
@@ -1501,6 +1507,7 @@ const struct usb_device_id wacom_ids[] = {
 	{ USB_DEVICE_WACOM(0xE2) },
 	{ USB_DEVICE_WACOM(0xE3) },
 	{ USB_DEVICE_WACOM(0x47) },
+	{ USB_DEVICE_LENOVO(0x6004) },
 	{ }
 };
 MODULE_DEVICE_TABLE(usb, wacom_ids);
-- 
1.7.3.4

[PATCH] Add support for the built-in digitizer in the Lenovo W700

[Ping Cheng]

From: Ajay Ramaswamy <ajay@ramaswamy.net>

The patch is based on git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next

Signed-off-by: Ajay Ramaswamy <ajay@ramaswamy.net>
Reviewed-by: Ping Cheng <pingc@wacom.com>
---
 drivers/input/tablet/wacom.h     |    1 +
 drivers/input/tablet/wacom_wac.c |    7 +++++++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/input/tablet/wacom.h b/drivers/input/tablet/wacom.h
index de5adb1..23317bd 100644
--- a/drivers/input/tablet/wacom.h
+++ b/drivers/input/tablet/wacom.h
@@ -103,6 +103,7 @@ MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE(DRIVER_LICENSE);
 
 #define USB_VENDOR_ID_WACOM	0x056a
+#define USB_VENDOR_ID_LENOVO	0x17ef
 
 struct wacom {
 	dma_addr_t data_dma;
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index 0b05254..0024d3e 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -1424,11 +1424,17 @@ static struct wacom_features wacom_features_0xD2 =
 	{ "Wacom Bamboo Craft",   WACOM_PKGLEN_BBFUN,     14720,  9200, 1023, 63, BAMBOO_PT };
 static struct wacom_features wacom_features_0xD3 =
 	{ "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13530, 1023, 63, BAMBOO_PT };
+static const struct wacom_features wacom_features_0x6004 =
+	{ "ISD-V4",               WACOM_PKGLEN_GRAPHIRE,  12800, 8000, 255, 0, TABLETPC };
 
 #define USB_DEVICE_WACOM(prod)					\
 	USB_DEVICE(USB_VENDOR_ID_WACOM, prod),			\
 	.driver_info = (kernel_ulong_t)&wacom_features_##prod
 
+#define USB_DEVICE_LENOVO(prod)					\
+	USB_DEVICE(USB_VENDOR_ID_LENOVO, prod),			\
+	.driver_info = (kernel_ulong_t)&wacom_features_##prod
+
 const struct usb_device_id wacom_ids[] = {
 	{ USB_DEVICE_WACOM(0x00) },
 	{ USB_DEVICE_WACOM(0x10) },
@@ -1501,6 +1507,7 @@ const struct usb_device_id wacom_ids[] = {
 	{ USB_DEVICE_WACOM(0xE2) },
 	{ USB_DEVICE_WACOM(0xE3) },
 	{ USB_DEVICE_WACOM(0x47) },
+	{ USB_DEVICE_LENOVO(0x6004) },
 	{ }
 };
 MODULE_DEVICE_TABLE(usb, wacom_ids);
-- 
1.7.3.4

Re: [PATCH] Add support for the built-in digitizer in the Lenovo W700

[Dmitry Torokhov]

On Wed, Dec 22, 2010 at 11:33:15AM -0800, Ping Cheng wrote:
> From: Ajay Ramaswamy <ajay@ramaswamy.net>
> 
> The patch is based on git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
> 
> Signed-off-by: Ajay Ramaswamy <ajay@ramaswamy.net>
> Reviewed-by: Ping Cheng <pingc@wacom.com>

Don't we need to add HID blacklist for this as well?

> ---
>  drivers/input/tablet/wacom.h     |    1 +
>  drivers/input/tablet/wacom_wac.c |    7 +++++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/tablet/wacom.h b/drivers/input/tablet/wacom.h
> index de5adb1..23317bd 100644
> --- a/drivers/input/tablet/wacom.h
> +++ b/drivers/input/tablet/wacom.h
> @@ -103,6 +103,7 @@ MODULE_DESCRIPTION(DRIVER_DESC);
>  MODULE_LICENSE(DRIVER_LICENSE);
>  
>  #define USB_VENDOR_ID_WACOM	0x056a
> +#define USB_VENDOR_ID_LENOVO	0x17ef
>  
>  struct wacom {
>  	dma_addr_t data_dma;
> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
> index 0b05254..0024d3e 100644
> --- a/drivers/input/tablet/wacom_wac.c
> +++ b/drivers/input/tablet/wacom_wac.c
> @@ -1424,11 +1424,17 @@ static struct wacom_features wacom_features_0xD2 =
>  	{ "Wacom Bamboo Craft",   WACOM_PKGLEN_BBFUN,     14720,  9200, 1023, 63, BAMBOO_PT };
>  static struct wacom_features wacom_features_0xD3 =
>  	{ "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13530, 1023, 63, BAMBOO_PT };
> +static const struct wacom_features wacom_features_0x6004 =
> +	{ "ISD-V4",               WACOM_PKGLEN_GRAPHIRE,  12800, 8000, 255, 0, TABLETPC };
>  
>  #define USB_DEVICE_WACOM(prod)					\
>  	USB_DEVICE(USB_VENDOR_ID_WACOM, prod),			\
>  	.driver_info = (kernel_ulong_t)&wacom_features_##prod
>  
> +#define USB_DEVICE_LENOVO(prod)					\
> +	USB_DEVICE(USB_VENDOR_ID_LENOVO, prod),			\
> +	.driver_info = (kernel_ulong_t)&wacom_features_##prod
> +
>  const struct usb_device_id wacom_ids[] = {
>  	{ USB_DEVICE_WACOM(0x00) },
>  	{ USB_DEVICE_WACOM(0x10) },
> @@ -1501,6 +1507,7 @@ const struct usb_device_id wacom_ids[] = {
>  	{ USB_DEVICE_WACOM(0xE2) },
>  	{ USB_DEVICE_WACOM(0xE3) },
>  	{ USB_DEVICE_WACOM(0x47) },
> +	{ USB_DEVICE_LENOVO(0x6004) },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(usb, wacom_ids);
> -- 
> 1.7.3.4
> 

-- 
Dmitry

Re: [PATCH] Add support for the built-in digitizer in the Lenovo W700

[Ping Cheng]

On Wed, Dec 22, 2010 at 11:47 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Wed, Dec 22, 2010 at 11:33:15AM -0800, Ping Cheng wrote:
>> From: Ajay Ramaswamy <ajay@ramaswamy.net>
>>
>> The patch is based on git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
>>
>> Signed-off-by: Ajay Ramaswamy <ajay@ramaswamy.net>
>> Reviewed-by: Ping Cheng <pingc@wacom.com>
>
> Don't we need to add HID blacklist for this as well?

I thought about that as well (I don't have a system to test with).
Ajay told me that he did not need to do anything in hid-core.c for his
tablet to work. He has been using/testing the tablet for more than 4
months.

Hopefully, we'll get more feedback from the community when the patch
gets in the tree.

Thank you.

Ping

>> ---
>>  drivers/input/tablet/wacom.h     |    1 +
>>  drivers/input/tablet/wacom_wac.c |    7 +++++++
>>  2 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/input/tablet/wacom.h b/drivers/input/tablet/wacom.h
>> index de5adb1..23317bd 100644
>> --- a/drivers/input/tablet/wacom.h
>> +++ b/drivers/input/tablet/wacom.h
>> @@ -103,6 +103,7 @@ MODULE_DESCRIPTION(DRIVER_DESC);
>>  MODULE_LICENSE(DRIVER_LICENSE);
>>
>>  #define USB_VENDOR_ID_WACOM  0x056a
>> +#define USB_VENDOR_ID_LENOVO 0x17ef
>>
>>  struct wacom {
>>       dma_addr_t data_dma;
>> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
>> index 0b05254..0024d3e 100644
>> --- a/drivers/input/tablet/wacom_wac.c
>> +++ b/drivers/input/tablet/wacom_wac.c
>> @@ -1424,11 +1424,17 @@ static struct wacom_features wacom_features_0xD2 =
>>       { "Wacom Bamboo Craft",   WACOM_PKGLEN_BBFUN,     14720,  9200, 1023, 63, BAMBOO_PT };
>>  static struct wacom_features wacom_features_0xD3 =
>>       { "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN,     21648, 13530, 1023, 63, BAMBOO_PT };
>> +static const struct wacom_features wacom_features_0x6004 =
>> +     { "ISD-V4",               WACOM_PKGLEN_GRAPHIRE,  12800, 8000, 255, 0, TABLETPC };
>>
>>  #define USB_DEVICE_WACOM(prod)                                       \
>>       USB_DEVICE(USB_VENDOR_ID_WACOM, prod),                  \
>>       .driver_info = (kernel_ulong_t)&wacom_features_##prod
>>
>> +#define USB_DEVICE_LENOVO(prod)                                      \
>> +     USB_DEVICE(USB_VENDOR_ID_LENOVO, prod),                 \
>> +     .driver_info = (kernel_ulong_t)&wacom_features_##prod
>> +
>>  const struct usb_device_id wacom_ids[] = {
>>       { USB_DEVICE_WACOM(0x00) },
>>       { USB_DEVICE_WACOM(0x10) },
>> @@ -1501,6 +1507,7 @@ const struct usb_device_id wacom_ids[] = {
>>       { USB_DEVICE_WACOM(0xE2) },
>>       { USB_DEVICE_WACOM(0xE3) },
>>       { USB_DEVICE_WACOM(0x47) },
>> +     { USB_DEVICE_LENOVO(0x6004) },
>>       { }
>>  };
>>  MODULE_DEVICE_TABLE(usb, wacom_ids);
>> --
>> 1.7.3.4
>>
>
> --
> Dmitry
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Add support for the built-in digitizer in the Lenovo W700

[Dmitry Torokhov]

On Wed, Dec 22, 2010 at 11:56:16AM -0800, Ping Cheng wrote:
> On Wed, Dec 22, 2010 at 11:47 AM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Wed, Dec 22, 2010 at 11:33:15AM -0800, Ping Cheng wrote:
> >> From: Ajay Ramaswamy <ajay@ramaswamy.net>
> >>
> >> The patch is based on git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
> >>
> >> Signed-off-by: Ajay Ramaswamy <ajay@ramaswamy.net>
> >> Reviewed-by: Ping Cheng <pingc@wacom.com>
> >
> > Don't we need to add HID blacklist for this as well?
> 
> I thought about that as well (I don't have a system to test with).
> Ajay told me that he did not need to do anything in hid-core.c for his
> tablet to work. He has been using/testing the tablet for more than 4
> months.
> 
> Hopefully, we'll get more feedback from the community when the patch
> gets in the tree.
> 

OK, fair enough, applied.

Thanks everyone.

-- 
Dmitry