From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ping Cheng <pinglinux@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 3/3 v2] input - wacom_w8001: Add one finger touch support
Date: Sun, 2 Jan 2011 22:33:14 -0800 [thread overview]
Message-ID: <20110103063314.GA26703@core.coreip.homeip.net> (raw)
In-Reply-To: <AANLkTimC_yHgEWdjmBNWb76Djyb_4+zOx5BJ4cgW4qbb@mail.gmail.com>
On Sun, Jan 02, 2011 at 08:59:39PM -0800, Ping Cheng wrote:
> On Sun, Jan 2, 2011 at 1:01 AM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Thu, Dec 30, 2010 at 10:25:20AM -0800, Ping Cheng wrote:
> >> On Wed, Dec 29, 2010 at 2:30 PM, Ping Cheng <pinglinux@gmail.com> wrote:
> >> > Dmitry,
> >> >
> >> > Thank you for your effort in updating the patch. Most changes work for
> >> > me. I do have comments related to raw touch data scaling for MT and
> >> > single touch legacy client support. Details are inline.
> >>
> >> After revisited the change you made, I think I can accept both
> >> suggestions. The legacy client support may introduce issue. But it
> >> won't hurt too much, I hope ;). The MT scaling offers a consistent
> >> support between one and two finger touch, which is good.
> >>
> >> So, the only change left is to scale the raw x,y of 2FGT to max_pen. I
> >> can make a version 3 of this patch for you or you can change those two
> >> lines if you don't mind. Just let me know.
> >
> > If there are such devices that have pen + 2FGT then please adjust the
> > patch as you should be able to test it ;)
>
> Yes, there are pen + 2FGT devices in the market now. Will update the patch soon.
>
> > Also, if you [re]send me inputattach part for 8001 I shoudl try adding
> > it to inputattach (it's not there yet, is it?).
>
> No, inputattach is not part of this patchset. I am not sure which
> inputattach.c source my patch should be based on. The one under your
> repo looks a bit old....
>
The one on the sourceforge should be recent.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-03 6:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 17:37 [PATCH 3/3 v2] input - wacom_w8001: Add one finger touch support Ping Cheng
2010-12-29 7:40 ` Dmitry Torokhov
2010-12-29 7:42 ` Dmitry Torokhov
2010-12-29 22:54 ` Ping Cheng
2011-01-02 8:59 ` Dmitry Torokhov
2010-12-29 22:30 ` Ping Cheng
2010-12-30 18:25 ` Ping Cheng
2011-01-02 9:01 ` Dmitry Torokhov
2011-01-03 4:59 ` Ping Cheng
2011-01-03 6:33 ` Dmitry Torokhov [this message]
2011-01-02 8:56 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103063314.GA26703@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).