From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mike Frysinger <vapier@gentoo.org>,
Michael Hennerich <michael.hennerich@analog.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: ad7879 - Convert I2C to dev_pm_ops
Date: Wed, 5 Jan 2011 22:41:46 +0000 [thread overview]
Message-ID: <20110105224145.GA5476@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110105221432.GA6086@core.coreip.homeip.net>
On Wed, Jan 05, 2011 at 02:14:32PM -0800, Dmitry Torokhov wrote:
> I do not think you tested it with !CONFIG_PM since &NULL is not valid
> expression (& requires an lvalue for operand).
Oh, fail. I knew there was a reason why dev_pm_ops stuff caused hassle.
But then I do have to wonder who exactly builds without PM enabled these
days.
> Please change to guard .pm = &ad7879_i2c_pm with #ifdef.
Meh, I guess. Though that ends up being annoying in general as some of
the PM functions (things like poweroff) are active even without PM
enabled, it always feels clearer to just have the struct there all the
time and carry on with the standard NULLs for functions.
next prev parent reply other threads:[~2011-01-05 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 19:01 [PATCH] Input: ad7879 - Convert I2C to dev_pm_ops Mark Brown
2011-01-05 22:14 ` Dmitry Torokhov
2011-01-05 22:41 ` Mark Brown [this message]
2011-01-06 0:09 ` Dmitry Torokhov
2011-01-06 0:37 ` Mark Brown
2011-01-06 12:15 ` Mark Brown
2011-01-07 1:15 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105224145.GA5476@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).