From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Fabien Marteau <fabien.marteau@armadeus.com>
Cc: Trilok Soni <tsoni@codeaurora.org>,
Scott Moreau <oreaus@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: joystick: Adding Austria Microsystem AS5011 joystick driver (third version)
Date: Fri, 7 Jan 2011 11:50:00 -0800 [thread overview]
Message-ID: <20110107195000.GD28875@core.coreip.homeip.net> (raw)
In-Reply-To: <4D276CAD.5090604@armadeus.com>
On Fri, Jan 07, 2011 at 08:42:37PM +0100, Fabien Marteau wrote:
> On 04/01/2011 12:01, Trilok Soni wrote:
> > Hi Fabien,
> >
> > On 1/4/2011 3:17 PM, Fabien Marteau wrote:
> >> +
> >> +static irqreturn_t as5011_int_interrupt(int irq, void *dev_id)
> >> +{
> >> + struct as5011_platform_data *plat_dat = dev_id;
> >> +
> >> + mutex_lock(&plat_dat->update_lock);
> >> + as5011_update_axes(plat_dat);
> >> + mutex_unlock(&plat_dat->update_lock);
> >
> > Please explain this lock. Sorry if I have missed out your explanation in the earlier threads.
>
> If a second interruption occurs the first update must be finished before update again.
The ISR handler will not be called simultaneously on several CPUs. What
else can it race with?
--
Dmitry
next prev parent reply other threads:[~2011-01-07 19:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 9:47 [PATCH] input: joystick: Adding Austria Microsystem AS5011 joystick driver (third version) Fabien Marteau
2011-01-04 11:01 ` Trilok Soni
2011-01-07 19:42 ` Fabien Marteau
2011-01-07 19:50 ` Dmitry Torokhov [this message]
2011-01-07 19:55 ` Fabien Marteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107195000.GD28875@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=fabien.marteau@armadeus.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oreaus@gmail.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).