From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Naveen Kumar GADDIPATI <naveen.gaddipati@stericsson.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
STEricsson_nomadik_linux <STEricsson_nomadik_linux@list.st.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"tsoni@codeaurora.org" <tsoni@codeaurora.org>,
"rydberg@euromail.se" <rydberg@euromail.se>,
Bengt JONSSON <bengt.g.jonsson@stericsson.com>
Subject: Re: [PATCH 1/2] input:Regulator support in ROHM BU21013 touch panel
Date: Wed, 12 Jan 2011 10:51:57 +0000 [thread overview]
Message-ID: <20110112105156.GB20911@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <81C3A93C17462B4BBD7E272753C1057919521AF64C@EXDCVYMBSTM005.EQ1STM.local>
On Wed, Jan 12, 2011 at 11:04:10AM +0100, Naveen Kumar GADDIPATI wrote:
> >> >On Wed, Jan 12, 2011 at 12:05:26PM +0530, Naveen Kumar G wrote:
> >So who/what cares about I2C device name? I do not see how this help
> >anything, but it does make device's name differ from its sysfs name.
> >I believe that driver should only alter names of objects they create and
> >leave other objects alone.
> In our regulator driver platform data, we used to differentiate with device name,
> which is more readable than the client device name. That is why we are sending it through platform data.
> If you are not preferable to use this, we could change it to client device name.
This is not what the regulator API is expecting you to do. The
regulator API is expecting you to use whatever the device name the
bus/device model ends up giving you by default is. If you want to
assign other device names for readability or similar reasons that's
another issue which should be taken up with the device core guys.
next prev parent reply other threads:[~2011-01-12 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 6:35 [PATCH 1/2] input:Regulator support in ROHM BU21013 touch panel Naveen Kumar G
2011-01-12 8:40 ` Dmitry Torokhov
2011-01-12 9:05 ` Naveen Kumar GADDIPATI
2011-01-12 9:15 ` Dmitry Torokhov
2011-01-12 10:04 ` Naveen Kumar GADDIPATI
2011-01-12 10:51 ` Mark Brown [this message]
2011-01-12 10:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112105156.GB20911@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=bengt.g.jonsson@stericsson.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=naveen.gaddipati@stericsson.com \
--cc=rydberg@euromail.se \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).