From: "Henrik Rydberg" <rydberg@bitmath.org>
To: Benjamin Tissoires <benjamin.tissoires@enac.fr>
Cc: Stephane Chatty <chatty@enac.fr>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hid-multitouch: changes from the review process
Date: Wed, 12 Jan 2011 13:27:41 +0100 [thread overview]
Message-ID: <20110112122741.GA29373@polaris.bitmath.org> (raw)
In-Reply-To: <AANLkTin86WMvEpNAm2T8wR=GgUBtYqoqGJxZm7hKnEoE@mail.gmail.com>
On Tue, Jan 11, 2011 at 06:38:24PM +0100, Benjamin Tissoires wrote:
> On Tue, Jan 11, 2011 at 6:35 PM, Henrik Rydberg <rydberg@bitmath.org> wrote:
> > On Tue, Jan 11, 2011 at 04:45:54PM +0100, Benjamin Tissoires wrote:
> >> * amended Kconfig (PixCir and Hanvon are the same panel but with
> >> different name)
> >> * insert field name in mt_class and retrieving it in mt_probe
> >> * add 2 quirks: MT_QUIRK_VALID_IS_INRANGE, MT_QUIRK_VALID_IS_CONFIDENCE,
> >> in order to find the field "valid"
> >> * inlined slot_is_contactid and slot_is_contact_number
> >> * cosmetics changes (tabs and comments)
> >> * do not send unnecessary properties once the touch is up
> >>
> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
> >
> > There are some syntactic suboptimalities in the resulting file that
> > perhaps could be fixed, but content-wise, I have nothing further. So,
> > given that it actually works,
> >
> > Acked-by: Henrik Rydberg <rydberg@euromail.se>
> >
> > Thank you very much for your work, Benjamin.
>
> Thanks for the review Henrik,
Regarding the quanta patches you have pending, IFAICT the 0408:3001
device is not properly supported currently, so perhaps that one could
be added to the list, too.
Cheers,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-12 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 15:45 [PATCH v2] hid-multitouch: changes from the review process Benjamin Tissoires
2011-01-11 17:35 ` Henrik Rydberg
2011-01-11 17:38 ` Benjamin Tissoires
2011-01-12 12:27 ` Henrik Rydberg [this message]
2011-01-12 13:01 ` Benjamin Tissoires
2011-01-12 14:13 ` Henrik Rydberg
2011-01-11 17:41 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112122741.GA29373@polaris.bitmath.org \
--to=rydberg@bitmath.org \
--cc=benjamin.tissoires@enac.fr \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).