linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: linux-input@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] sysrq is half-enabled by default
Date: Sat, 15 Jan 2011 13:54:50 -0800	[thread overview]
Message-ID: <20110115215450.GB19872@core.coreip.homeip.net> (raw)
In-Reply-To: <1295123037-2649-1-git-send-email-apw@canonical.com>

Hi Andy,

On Sat, Jan 15, 2011 at 08:23:56PM +0000, Andy Whitcroft wrote:
> It seems that recent cleanups to sysrq handling have lead to us having
> two copies of the sysrq enable status.  At boot these are currently
> inconsistently specified leading to sysrq actually being enabled but
> reported as not enabled in sysfs.  Following this email is a patch to
> link both of these copies to a common configuration setting.
> 

Thanks for noticing this, but I do not think we need a new configuration
parameter. We did not have it for about 10 years and distributions know
how to disable it upon boot if they want to.

Do youthink you could cange the patch and add a default value (1) to
inlude/linux/sysrq.h and use it in sysctl and the handler code?

Thanks!

-- 
Dmitry

  parent reply	other threads:[~2011-01-15 21:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-15 20:23 [PATCH 0/1] sysrq is half-enabled by default Andy Whitcroft
2011-01-15 20:23 ` [PATCH 1/1] Input: sysrq -- ensure sysrq_enabled and __sysrq_enabled are consistent Andy Whitcroft
2011-01-15 21:54 ` Dmitry Torokhov [this message]
2011-01-18  9:38   ` [PATCH 0/1] sysrq is half-enabled by default Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110115215450.GB19872@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@suse.de \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).