From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Ross <andy.ross@windriver.com>
Cc: Corentin Chary <corentincj@iksaif.net>,
linux-input@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 0/2] Pegatron Lucid tablet accelerometer
Date: Mon, 17 Jan 2011 10:49:28 -0800 [thread overview]
Message-ID: <20110117184927.GA27245@core.coreip.homeip.net> (raw)
In-Reply-To: <1295287011-12849-1-git-send-email-andy.ross@windriver.com>
On Mon, Jan 17, 2011 at 09:56:49AM -0800, Andy Ross wrote:
>
> > > + ipdev->input->dev.release = dev_noop_release;
> >
> > WTH is this???
>
> It's an attempt to avoid this from drivers/base/core.c:
>
> WARN(1, KERN_ERR "Device '%s' does not have a release() "
> "function, it is broken and must be fixed.\n",
> dev_name(dev));
>
> ...but it was in the wrong place. The input device doesn't hit that
> path, the platform device does. Moved to where it belongs.
>
It does not belong anywhere. Please create platform device dynamically
(for example using platfrom_device_register_simple) and destroy it when
done.
The only time when static devices are [semi-]allowed (Greg has differing
opioon on this I believe) is in platform/arch code for devices that can
never be destroyed.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-01-17 18:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 17:56 [PATCH 0/2] Pegatron Lucid tablet accelerometer Andy Ross
2011-01-17 17:56 ` [PATCH 1/2] input: Pegatron Lucid accelerometer Andy Ross
2011-01-18 5:48 ` Shubhrajyoti
2011-01-18 5:59 ` Dmitry Torokhov
2011-01-18 17:21 ` Andy Ross
[not found] ` <4D35CC1B.3020808-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2011-01-31 21:30 ` Matthew Garrett
2011-03-18 15:39 ` Anisse Astier
2011-01-17 17:56 ` [PATCH 2/2] asus-laptop: Support pega_accel driver Andy Ross
2011-01-17 18:49 ` Dmitry Torokhov [this message]
2011-01-17 22:14 ` [PATCH 0/2] Pegatron Lucid tablet accelerometer Andy Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117184927.GA27245@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy.ross@windriver.com \
--cc=corentincj@iksaif.net \
--cc=linux-input@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).