From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] i8042 driver for unicore32 architecture Date: Mon, 17 Jan 2011 20:11:11 -0800 Message-ID: <20110118041111.GA23678@core.coreip.homeip.net> References: <005b01cbb594$6398d9e0$2aca8da0$@mprc.pku.edu.cn> <20110117173932.GB15404@core.coreip.homeip.net> <00fd01cbb6c0$327510e0$975f32a0$@mprc.pku.edu.cn> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-gy0-f174.google.com ([209.85.160.174]:49573 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752641Ab1ARESf (ORCPT ); Mon, 17 Jan 2011 23:18:35 -0500 Received: by gyb11 with SMTP id 11so2173852gyb.19 for ; Mon, 17 Jan 2011 20:18:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <00fd01cbb6c0$327510e0$975f32a0$@mprc.pku.edu.cn> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Guan Xuetao Cc: linux-input@vger.kernel.org On Tue, Jan 18, 2011 at 11:31:30AM +0800, Guan Xuetao wrote: > > > diff --git a/drivers/staging/puv3/i8042-ucio.h b/drivers/staging/puv3/i8042-ucio.h > > > new file mode 100644 > > > index 0000000..c3221df > > > --- /dev/null > > > +++ b/drivers/staging/puv3/i8042-ucio.h > > > @@ -0,0 +1,89 @@ > > > +/* > > > + * linux/drivers/staging/puv3/i8042-ucio.h > > > > Please do not put filenames in the comments. > That's ok. > But why? Because: 1. It does not convey any additional information - your editor is sure capable of displaying the filename associated with a buffer, and 2. It is one more thing that needs updating if you decide to move/rename the file. > > > + > > > +static inline int i8042_platform_init(void) > > > +{ > > > +/* > > > + * On some platforms touching the i8042 data register region can do really > > > + * bad things. Because of this the region is always reserved on such boxes. > > > + */ > > > > The comment is in wrong place and is not applicable to your arch I > > think. > Ok, removed. Request_region and release_region are also removed. So are the regions reserved elsewhere? Might be a good idea to note this fact. Thanks. -- Dmitry