From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jamie Iles <jamie@jamieiles.com>
Cc: linux-kernel@vger.kernel.org, Cyril Chemparathy <cyril@ti.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 04/16] input: tnetv107x-touchscreen: don't treat NULL clk as an error
Date: Mon, 17 Jan 2011 20:35:55 -0800 [thread overview]
Message-ID: <20110118043555.GA23851@core.coreip.homeip.net> (raw)
In-Reply-To: <20110118042535.GA23781@core.coreip.homeip.net>
On Mon, Jan 17, 2011 at 08:25:35PM -0800, Dmitry Torokhov wrote:
> On Tue, Jan 11, 2011 at 09:56:41PM -0800, Dmitry Torokhov wrote:
> > On Tue, Jan 11, 2011 at 12:43:41PM +0000, Jamie Iles wrote:
> > > clk_get() returns a struct clk cookie to the driver and some platforms
> > > may return NULL if they only support a single clock. clk_get() has only
> > > failed if it returns a ERR_PTR() encoded pointer.
> > >
> > > Cc: Cyril Chemparathy <cyril@ti.com>
> > > Cc: linux-input@vger.kernel.org
> > > Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> >
> > Applied both, thank you Jamie.
> >
>
> Actually, if we pass clk that is NULL along we going to get oops on many
> arches, so I am going to change it to IS_ERR_OR_NULL.
>
Oh, wait... OK, I got confused by the changelog. IS_ERR is proper,
sorry.
--
Dmitry
prev parent reply other threads:[~2011-01-18 4:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1294749833-32019-1-git-send-email-jamie@jamieiles.com>
2011-01-11 12:43 ` [PATCH 03/16] input: tnetv107x-keypad: don't treat NULL clk as an error Jamie Iles
2011-01-11 12:43 ` [PATCH 04/16] input: tnetv107x-touchscreen: " Jamie Iles
2011-01-12 5:56 ` Dmitry Torokhov
2011-01-18 4:25 ` Dmitry Torokhov
2011-01-18 4:35 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118043555.GA23851@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=cyril@ti.com \
--cc=jamie@jamieiles.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).