From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Guan Xuetao <guanxuetao@mprc.pku.edu.cn>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] i8042 driver for unicore32 architecture
Date: Mon, 17 Jan 2011 20:52:19 -0800 [thread overview]
Message-ID: <20110118045219.GB23851@core.coreip.homeip.net> (raw)
In-Reply-To: <012501cbb6ca$7a48ee00$6edaca00$@mprc.pku.edu.cn>
On Tue, Jan 18, 2011 at 12:45:06PM +0800, Guan Xuetao wrote:
>
>
> > -----Original Message-----
> > From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> > Sent: Tuesday, January 18, 2011 12:11 PM
> > To: Guan Xuetao
> > Cc: linux-input@vger.kernel.org
> > Subject: Re: [PATCH] i8042 driver for unicore32 architecture
> >
> > On Tue, Jan 18, 2011 at 11:31:30AM +0800, Guan Xuetao wrote:
> > > > > diff --git a/drivers/staging/puv3/i8042-ucio.h b/drivers/staging/puv3/i8042-ucio.h
> > > > > new file mode 100644
> > > > > index 0000000..c3221df
> > > > > --- /dev/null
> > > > > +++ b/drivers/staging/puv3/i8042-ucio.h
> > > > > @@ -0,0 +1,89 @@
> > > > > +/*
> > > > > + * linux/drivers/staging/puv3/i8042-ucio.h
> > > >
> > > > Please do not put filenames in the comments.
> > > That's ok.
> > > But why?
> >
> > Because:
> >
> > 1. It does not convey any additional information - your editor is sure
> > capable of displaying the filename associated with a buffer, and
> >
> > 2. It is one more thing that needs updating if you decide to move/rename
> > the file.
> I see.
>
> >
> > > > > +
> > > > > +static inline int i8042_platform_init(void)
> > > > > +{
> > > > > +/*
> > > > > + * On some platforms touching the i8042 data register region can do really
> > > > > + * bad things. Because of this the region is always reserved on such boxes.
> > > > > + */
> > > >
> > > > The comment is in wrong place and is not applicable to your arch I
> > > > think.
> > > Ok, removed. Request_region and release_region are also removed.
> >
> > So are the regions reserved elsewhere? Might be a good idea to note this
> > fact.
> Not reserved. I think it unnecessary, since in unicore32, user application can't acess
> io space directly.
It is not for benefit of userspace applications, it is to ensure that 2
drivers do not try to access the same ports.
So please put request_region and release_region back ;)
--
Dmitry
prev parent reply other threads:[~2011-01-18 4:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 15:45 [PATCH] i8042 driver for unicore32 architecture Guan Xuetao
2011-01-17 17:39 ` Dmitry Torokhov
2011-01-18 3:31 ` Guan Xuetao
2011-01-18 4:11 ` Dmitry Torokhov
2011-01-18 4:45 ` Guan Xuetao
2011-01-18 4:52 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118045219.GB23851@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=guanxuetao@mprc.pku.edu.cn \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).