From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rakesh Iyer <riyer@nvidia.com>
Cc: "tsoni@codeaurora.org" <tsoni@codeaurora.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"shubhrajyoti@ti.com" <shubhrajyoti@ti.com>,
"ccross@android.com" <ccross@android.com>,
"konkers@android.com" <konkers@android.com>,
"olof@lixom.net" <olof@lixom.net>, Andrew Chew <AChew@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH v5] input: tegra-kbc - Add tegra keyboard driver
Date: Tue, 18 Jan 2011 21:23:24 -0800 [thread overview]
Message-ID: <20110119052324.GA27751@core.coreip.homeip.net> (raw)
In-Reply-To: <1FC56210173BB445BD77F608D6FB8D03165A00807E@HQMAIL03.nvidia.com>
On Tue, Jan 18, 2011 at 07:28:29PM -0800, Rakesh Iyer wrote:
> Sorry for the late response as I was not working on it on Monday.
>
> The patch as is did not work. I am debugging this currently.
Sorry about that. If you describe the effects you are seeing I might try
to think where I messed up.
>
> Once I find a fix, can I resend all the driver code as one patch file?
> I will include your 2nd patch in it as well.
Sure.
>
> Secondly, the driver is a platform driver for Tegra platforms. The
> platform code needs some of the #defines to be present in kbc.h, so
> you will see some of the defines moved back to kbc.h from tegra-kbc.c
>
I only moved KBC_MAX_COL, KBC_MAX_ROW and KBC_MAX_KEY since they are
not needed in keymaps expressed via struct matrix_keypad_data. But if
they are needed for something else that's fine.
--
Dmitry
prev parent reply other threads:[~2011-01-19 5:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 18:27 [PATCH v5] input: tegra-kbc - Add tegra keyboard driver riyer
2011-01-18 5:12 ` Dmitry Torokhov
2011-01-18 5:13 ` Dmitry Torokhov
2011-01-19 3:28 ` Rakesh Iyer
2011-01-19 5:23 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119052324.GA27751@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=AChew@nvidia.com \
--cc=ccross@android.com \
--cc=konkers@android.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=pavel@ucw.cz \
--cc=riyer@nvidia.com \
--cc=shubhrajyoti@ti.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).