From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
Mike Frysinger <vapier@gentoo.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/3] Input: ad7979 - Convert SPI to dev_pm_ops
Date: Wed, 19 Jan 2011 10:53:54 -0800 [thread overview]
Message-ID: <20110119185354.GC29107@core.coreip.homeip.net> (raw)
In-Reply-To: <20110119183916.GB17150@opensource.wolfsonmicro.com>
On Wed, Jan 19, 2011 at 06:39:16PM +0000, Mark Brown wrote:
> On Wed, Jan 19, 2011 at 09:40:38AM -0800, Dmitry Torokhov wrote:
>
> > I was looking at SIMPLE_DEV_PM_OPS definition and it turns into noop if
> > CONFIG_PM_SLEEP is not set (for systems with runtime PM only, for
> > example). This will lead to "unused function" compiler warnings (and I
> > think I have seen such reports for randconfig compiles off linux-next).
>
> > Do you think we coudl augment your patch thusly:
>
> Looks sane to me - do you want me to redo the updates?
If it is not too much bother...
--
Dmitry
next prev parent reply other threads:[~2011-01-19 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 12:45 [PATCH 1/3] Input: ad7877 - Convert to dev_pm_ops Mark Brown
2011-01-19 12:45 ` [PATCH 2/3] Input: ad7979 - Convert SPI " Mark Brown
2011-01-19 17:40 ` Dmitry Torokhov
2011-01-19 18:39 ` Mark Brown
2011-01-19 18:53 ` Dmitry Torokhov [this message]
2011-01-19 12:45 ` [PATCH 3/3] Input: ads7846 - Convert " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119185354.GC29107@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-input@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).