From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: riyer@nvidia.com
Cc: tsoni@codeaurora.org, pavel@ucw.cz, shubhrajyoti@ti.com,
ccross@android.com, konkers@android.com, olof@lixom.net,
achew@nvidia.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v6] input: tegra-kbc - Add tegra keyboard driver
Date: Wed, 19 Jan 2011 14:58:34 -0800 [thread overview]
Message-ID: <20110119225834.GA29284@core.coreip.homeip.net> (raw)
In-Reply-To: <1295476207-15331-1-git-send-email-riyer@nvidia.com>
On Wed, Jan 19, 2011 at 02:30:07PM -0800, riyer@nvidia.com wrote:
> +
> +static void tegra_kbc_report_keys(struct tegra_kbc *kbc)
> +{
> + unsigned char scancodes[KBC_MAX_KPENT];
> + unsigned short keycodes[KBC_MAX_KPENT];
> + u32 val = 0;
> + unsigned int i;
> + unsigned int num_down = 0;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&kbc->lock, flags);
> + for (i = 0; i < KBC_MAX_KPENT * 4; i++) {
This will cause going beyond scancodes[] and keycodes[] and stomping on
your stack...
--
Dmitry
prev parent reply other threads:[~2011-01-19 22:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 22:30 [PATCH v6] input: tegra-kbc - Add tegra keyboard driver riyer
2011-01-19 22:58 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119225834.GA29284@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=achew@nvidia.com \
--cc=ccross@android.com \
--cc=konkers@android.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=pavel@ucw.cz \
--cc=riyer@nvidia.com \
--cc=shubhrajyoti@ti.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).