From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input: replace request_irq by request_any_context_irq in keyboard GPIO driver Date: Wed, 19 Jan 2011 23:53:48 -0800 Message-ID: <20110120075348.GE30522@core.coreip.homeip.net> References: <1294825292-24134-1-git-send-email-philippe.langlais@stericsson.com> <1294825292-24134-2-git-send-email-philippe.langlais@stericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:41582 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070Ab1ATHxz (ORCPT ); Thu, 20 Jan 2011 02:53:55 -0500 Received: by iyj18 with SMTP id 18so293916iyj.19 for ; Wed, 19 Jan 2011 23:53:55 -0800 (PST) Content-Disposition: inline In-Reply-To: <1294825292-24134-2-git-send-email-philippe.langlais@stericsson.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Philippe Langlais Cc: linux-input@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, Trilok Soni Hi Philippe, On Wed, Jan 12, 2011 at 10:41:32AM +0100, Philippe Langlais wrote: > Signed-off-by: Philippe Langlais > --- > drivers/input/keyboard/gpio_keys.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c > index 6069abe..eb30063 100644 > --- a/drivers/input/keyboard/gpio_keys.c > +++ b/drivers/input/keyboard/gpio_keys.c > @@ -322,7 +322,7 @@ static void gpio_keys_report_event(struct gpio_button_data *bdata) > struct gpio_keys_button *button = bdata->button; > struct input_dev *input = bdata->input; > unsigned int type = button->type ?: EV_KEY; > - int state = (gpio_get_value(button->gpio) ? 1 : 0) ^ button->active_low; > + int state = (gpio_get_value_cansleep(button->gpio) ? 1 : 0) ^ button->active_low; > > input_event(input, type, button->code, !!state); > input_sync(input); > @@ -410,8 +410,8 @@ static int __devinit gpio_keys_setup_key(struct platform_device *pdev, > if (!button->can_disable) > irqflags |= IRQF_SHARED; > > - error = request_irq(irq, gpio_keys_isr, irqflags, desc, bdata); > - if (error) { > + error = request_any_context_irq(irq, gpio_keys_isr, irqflags, desc, bdata); > + if (error < 0) { No, this it not correct. request_any_context_irq() means that you could either get a hardirq or a treaded one. However above you are changing to gpio_get_value_cansleep() which indicates that you can sleep. You need to either revert to gpio_get_value() or explicitly request threaded IRQ. Thanks. -- Dmitry