From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: David Engraf <david.engraf@sysgo.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serio: allow registered drivers to get status flag
Date: Wed, 26 Jan 2011 09:00:43 -0800 [thread overview]
Message-ID: <20110126170043.GB29168@core.coreip.homeip.net> (raw)
In-Reply-To: <4D3FEB2A.8010000@sysgo.com>
On Wed, Jan 26, 2011 at 10:36:42AM +0100, David Engraf wrote:
> Am 20.01.2011 10:05, schrieb David Engraf:
> >Am 18.01.2011 20:57, schrieb Dmitry Torokhov:
> >>On Tue, Jan 18, 2011 at 01:57:21PM +0100, David Engraf wrote:
> >>>Parse the status byte information to the registered serio drivers as
> >>>well as the character bytes.
> >>>
> >>>Signed-off-by: David Engraf<david.engraf@sysgo.com>
> >>>
> >>
> >>>--- linux-2.6.37/drivers/input/serio/serport.c.orig 2011-01-18
> >>>12:33:41.421709232 +0100
> >>>+++ linux-2.6.37/drivers/input/serio/serport.c 2011-01-18
> >>>13:33:24.521711214 +0100
> >>>@@ -116,8 +116,8 @@ static void serport_ldisc_close(struct t
> >>>
> >>>/*
> >>>* serport_ldisc_receive() is called by the low level tty driver when
> >>>characters
> >>>- * are ready for us. We forward the characters, one by one to the
> >>>'interrupt'
> >>>- * routine.
> >>>+ * are ready for us. We forward the characters and flags, one by one
> >>>to the
> >>>+ * 'interrupt' routine.
> >>>*/
> >>>
> >>>static void serport_ldisc_receive(struct tty_struct *tty, const
> >>>unsigned char *cp, char *fp, int count)
> >>>@@ -132,7 +132,7 @@ static void serport_ldisc_receive(struct
> >>>goto out;
> >>>
> >>>for (i = 0; i< count; i++)
> >>>- serio_interrupt(serport->serio, cp[i], 0);
> >>>+ serio_interrupt(serport->serio, cp[i], fp[i]);
> >>>
> >>
> >>Hi David,
> >>
> >>The flags argument that serio_interrupt() accepts not the raw protocol
> >>data, but sanitized, protocol-independent SERIO_TIMEOUT, SERIO_PARITY
> >>and SERIO_FRAME bits.
> >>
> >>Thanks.
> >>
> >
> >Hi Dmitry,
> >
> >I've updated the patch so that the raw protocol is converted to the
> >SERIO_ bits. The raw protocol can parse only one flag, so I don't need
> >to store multiple SERIO_ bits in the character flag variable.
> >
> >Thanks
> >- David
> >
> >
> >Signed-off-by: David Engraf<david.engraf@sysgo.com>
> >
>
> Hi Dmitry,
>
> is my last patch okay for you? Just want to know if I can give you
> further help on this and if it is planned to integrate my patch.
>
Hi David,
The patch should hit mainline real soon now, no action is needed on your
part.
Thanks.
--
Dmitry
prev parent reply other threads:[~2011-01-26 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 12:57 [PATCH] serio: allow registered drivers to get status flag David Engraf
2011-01-18 19:57 ` Dmitry Torokhov
2011-01-20 9:05 ` David Engraf
2011-01-26 9:36 ` David Engraf
2011-01-26 17:00 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126170043.GB29168@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=david.engraf@sysgo.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).