From: "Henrik Rydberg" <rydberg@euromail.se>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
baruch@tkos.co.il
Subject: Re: [PATCHv2] evdev: fix evdev_write return value on partial writes
Date: Thu, 27 Jan 2011 13:26:25 +0100 [thread overview]
Message-ID: <20110127122625.GD15626@polaris.bitmath.org> (raw)
In-Reply-To: <87pqrir1r2.fsf@macbook.be.48ers.dk>
On Thu, Jan 27, 2011 at 01:04:49PM +0100, Peter Korsgaard wrote:
> >>>>> "Henrik" == Henrik Rydberg <rydberg@euromail.se> writes:
>
> Hi,
>
> Henrik> I won't argue against this case (with < 0) being frequent, but one
> Henrik> should really check "n < len" to be safe. Hopefully Dmitry has some
> Henrik> more input.
>
> No, the point is that write (and read) can consume less data than
> requested, without it being an error. Robust userspace code should
> adjust buffer address / size and redo the work until all data is
> transferred or an error occurs.
Shouldn't the error be on (!len || len % smallest_acceptable_chunk),
then? Which makes me wonder about regressions - perhaps accumulating
partial writes in evdev is more safe from that perspective.
Thanks,
Henrik
next prev parent reply other threads:[~2011-01-27 12:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 10:03 [PATCHv2] evdev: fix evdev_write return value on partial writes Peter Korsgaard
2011-01-27 11:02 ` Henrik Rydberg
2011-01-27 11:21 ` Peter Korsgaard
2011-01-27 11:26 ` Baruch Siach
2011-01-27 11:29 ` Peter Korsgaard
2011-01-27 11:47 ` Henrik Rydberg
2011-01-27 12:04 ` Peter Korsgaard
2011-01-27 12:26 ` Henrik Rydberg [this message]
2011-01-27 12:43 ` Peter Korsgaard
2011-02-04 8:46 ` Dmitry Torokhov
2011-02-04 10:24 ` Henrik Rydberg
2011-02-04 11:00 ` Peter Korsgaard
2011-02-04 11:23 ` Henrik Rydberg
2011-02-04 17:15 ` Dmitry Torokhov
2011-02-04 17:22 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127122625.GD15626@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=baruch@tkos.co.il \
--cc=dmitry.torokhov@gmail.com \
--cc=jacmet@sunsite.dk \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).