linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@enac.fr>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>,
	Stephane Chatty <chatty@lii-enac.fr>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] hid-multitouch: introduce IrTouch Infrared USB device
Date: Fri, 28 Jan 2011 18:21:39 +0100	[thread overview]
Message-ID: <20110128172139.GB2586@polaris.bitmath.org> (raw)
In-Reply-To: <1296230680-2871-2-git-send-email-benjamin.tissoires@enac.fr>

On Fri, Jan 28, 2011 at 05:04:40PM +0100, Benjamin Tissoires wrote:
> The product id is the 42 inches one. I don't know if they have
> other product id for the other size, or if it is a per-size product id.
> 
> Tested-by: Victor Zhuk <v.zhuk@acs-ltd.ru>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
> ---

The canonical patch description presents the reason for the change,
and what the patch does (not necessarily how).

>  drivers/hid/Kconfig          |    1 +
>  drivers/hid/hid-ids.h        |    3 +++
>  drivers/hid/hid-multitouch.c |    5 +++++
>  3 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 24cca2f..a0b117d 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -304,6 +304,7 @@ config HID_MULTITOUCH
>  	  Say Y here if you have one of the following devices:
>  	  - Cypress TrueTouch panels
>  	  - Hanvon dual touch panels
> +	  - IrTouch Infrared USB panels
>  	  - Pixcir dual touch panels
>  	  - 'Sensing Win7-TwoFinger' panel by GeneralTouch
>  
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 92a0d61..b1dd7ad 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -333,6 +333,9 @@
>  #define USB_VENDOR_ID_IMATION		0x0718
>  #define USB_DEVICE_ID_DISC_STAKKA	0xd000
>  
> +#define USB_VENDOR_ID_IRTOUCHSYSTEMS	0x6615
> +#define USB_DEVICE_ID_IRTOUCH_INFRARED_USB	0x0070
> +
>  #define USB_VENDOR_ID_JESS		0x0c45
>  #define USB_DEVICE_ID_JESS_YUREX	0x1010
>  
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index ffe2a76..1629296 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -475,6 +475,11 @@ static const struct hid_device_id mt_devices[] = {
>  		HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH,
>  			USB_DEVICE_ID_GENERAL_TOUCH_WIN7_TWOFINGERS) },
>  
> +	/* IRTOUCH panels */
> +	{ .driver_data = MT_CLS_DUAL_INRANGE_CONTACTID,
> +		HID_USB_DEVICE(USB_VENDOR_ID_IRTOUCHSYSTEMS,
> +			USB_DEVICE_ID_IRTOUCH_INFRARED_USB) },
> +
>  	/* PixCir-based panels */
>  	{ .driver_data = MT_CLS_DUAL_INRANGE_CONTACTID,
>  		HID_USB_DEVICE(USB_VENDOR_ID_HANVON,
> -- 
> 1.7.3.4
> 

Thanks,
Henrik

  parent reply	other threads:[~2011-01-28 17:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-28 16:04 [PATCH 1/2] hid-multitouch: work on default classes and renaming of classes Benjamin Tissoires
2011-01-28 16:04 ` [PATCH 2/2] hid-multitouch: introduce IrTouch Infrared USB device Benjamin Tissoires
2011-01-28 16:24   ` [2/2] " Florian Echtler
2011-01-28 16:59     ` Benjamin Tissoires
2011-01-28 17:21   ` Henrik Rydberg [this message]
2011-01-28 17:59     ` [PATCH 2/2] " Benjamin Tissoires
2011-01-28 18:49       ` Henrik Rydberg
2011-01-28 17:18 ` [PATCH 1/2] hid-multitouch: work on default classes and renaming of classes Henrik Rydberg
2011-01-28 17:52   ` Benjamin Tissoires
2011-01-28 18:43     ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110128172139.GB2586@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=benjamin.tissoires@enac.fr \
    --cc=chatty@lii-enac.fr \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).