From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@enac.fr>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Ping Cheng <pingc@wacom.com>, Jiri Kosina <jkosina@suse.cz>,
Chris Bagwell <chris@cnpbagwell.com>,
Rafi Rubin <rafi@seas.upenn.edu>,
Stephane Chatty <chatty@lii-enac.fr>,
Peter Hutterer <peter.hutterer@who-t.net>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/2] input: mt: Add method to extract the MT slot state
Date: Fri, 28 Jan 2011 19:34:13 +0100 [thread overview]
Message-ID: <20110128183413.GA2553@polaris.bitmath.org> (raw)
In-Reply-To: <AANLkTikM-DguswOb6Hv5jgkrirfFf+MHTJgK_Xk45gz5@mail.gmail.com>
> > Thanks for the patches, Benjamin, perhaps they do need a bit of
> > rewrite or a new ioctl. We will see what happens.
> >
>
> Today I found a bug in these 2 patches: they send garbage with
> devices that use protocol A.
> This is definitely a bad idea to send the input_absinfo.
>
> In addition to that, using the original behavior (which seems better)
> does not seems to add sth in regard to input_mt_get_value.
> It would just add some guards that can be resumed in just a test:
> (code >= ABS_MT_FIRST && code <= ABS_MT_LAST && dev->mt &&
> slot >= 0 && slot < dev->mtsize)
>
> Henrik, if you want to introduce the new IOCTL, feel free, I don't
> need it right now.
Ok - for the record, neither of us actually re-initiated this thing,
so it still falls into the nice-to-have category. The good thing is
there is now a clear path on how to proceed.
Thanks Benjamin.
Henrik
next prev parent reply other threads:[~2011-01-28 18:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 10:35 [RFC 0/2] Add EVIOC mechanism to extract the MT slot state Benjamin Tissoires
2011-01-27 10:35 ` [RFC 1/2] input: mt: Add method " Benjamin Tissoires
2011-01-27 10:35 ` [RFC 2/2] input: evdev: Add EVIOC mechanism " Benjamin Tissoires
[not found] ` <1296124547-3323-2-git-send-email-benjamin.tissoires@enac.fr>
2011-01-27 12:06 ` [RFC 1/2] input: mt: Add method " Henrik Rydberg
2011-01-27 12:49 ` Benjamin Tissoires
2011-01-28 17:33 ` Henrik Rydberg
2011-01-28 18:10 ` Benjamin Tissoires
2011-01-28 18:34 ` Henrik Rydberg [this message]
[not found] ` <1296124547-3323-3-git-send-email-benjamin.tissoires@enac.fr>
2011-01-27 12:09 ` [RFC 2/2] input: evdev: Add EVIOC mechanism " Henrik Rydberg
2011-01-28 17:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110128183413.GA2553@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=benjamin.tissoires@enac.fr \
--cc=chatty@lii-enac.fr \
--cc=chris@cnpbagwell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=pingc@wacom.com \
--cc=rafi@seas.upenn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).