linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: riyer@nvidia.com
Cc: olof@lixom.net, achew@nvidia.com, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v1] input: tegra-kbc: Fix build error.
Date: Fri, 28 Jan 2011 14:09:52 -0800	[thread overview]
Message-ID: <20110128220952.GK6252@core.coreip.homeip.net> (raw)
In-Reply-To: <1296252213-15003-1-git-send-email-riyer@nvidia.com>

On Fri, Jan 28, 2011 at 02:03:33PM -0800, riyer@nvidia.com wrote:
> From: Rakesh Iyer <riyer@nvidia.com>
> 
> Fix build error introduced by variable name change.
> 

Did I manage to pick up wrong version?

> Signed-off-by: Rakesh Iyer <riyer@nvidia.com>
> ---
>  drivers/input/keyboard/tegra-kbc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index 6ca903a..ac471b7 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -355,8 +355,8 @@ static void tegra_kbc_config_pins(struct tegra_kbc *kbc)
>  	for (i = 0; i < KBC_MAX_GPIO; i++) {
>  		u32 r_shft = 5 * (i % 6);
>  		u32 c_shft = 4 * (i % 8);
> -		u32 r_mask = 0x1f << r_shift;
> -		u32 c_mask = 0x0f << c_shift;
> +		u32 r_mask = 0x1f << r_shft;
> +		u32 c_mask = 0x0f << c_shft;
>  		u32 r_offs = (i / 6) * 4 + KBC_ROW_CFG0_0;
>  		u32 c_offs = (i / 8) * 4 + KBC_COL_CFG0_0;
>  		u32 row_cfg = readl(kbc->mmio + r_offs);
> -- 
> 1.7.0.4
> 

-- 
Dmitry

  reply	other threads:[~2011-01-28 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-28 22:03 [PATCH v1] input: tegra-kbc: Fix build error riyer
2011-01-28 22:09 ` Dmitry Torokhov [this message]
2011-01-28 22:18   ` Rakesh Iyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110128220952.GK6252@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=achew@nvidia.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=riyer@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).