From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Iiro Valkonen <iiro.valkonen@atmel.com>
Cc: Trilok Soni <tsoni@codeaurora.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/5] Remove fixed config data from driver file; add config to platform data
Date: Fri, 4 Feb 2011 00:57:54 -0800 [thread overview]
Message-ID: <20110204085754.GE13046@core.coreip.homeip.net> (raw)
In-Reply-To: <4D4AB52D.4020400@atmel.com>
On Thu, Feb 03, 2011 at 04:01:17PM +0200, Iiro Valkonen wrote:
> + if (pdata->config) {
> + init_vals = (u8 *)pdata->config;
> + } else {
> + dev_err(dev, "No cfg data defined, skipping reg init\n");
> + return 0;
> }
>
> for (i = 0; i < data->info.object_num; i++) {
> diff --git a/include/linux/i2c/qt602240_ts.h b/include/linux/i2c/qt602240_ts.h
> index 0b4c72f..130f8bc 100644
> --- a/include/linux/i2c/qt602240_ts.h
> +++ b/include/linux/i2c/qt602240_ts.h
> @@ -33,6 +33,7 @@ struct mxt_platform_data {
> unsigned int threshold;
> unsigned int voltage;
> unsigned char orient;
> + unsigned char *config;
This should be "const u8 *config". Also it would be a good idea to also
pass length and validate it when dereferencing.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-02-04 8:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 16:52 [PATCH] input: Modify the qt602240 driver to be compatible with mXT1386 device Iiro Valkonen
2011-01-24 17:07 ` Dmitry Torokhov
2011-01-25 10:33 ` [PATCH 1/2] input: Modify the qt602240 driver to be compatible with mXT1386 device - renames Iiro Valkonen
2011-01-25 11:00 ` Trilok Soni
2011-01-27 11:32 ` Trilok Soni
2011-02-01 8:45 ` Valkonen, Iiro
2011-02-03 7:29 ` Dmitry Torokhov
2011-01-25 10:37 ` [PATCH 2/2] input: Modify the qt602240 driver to be compatible with mXT1386 device - functional changes Iiro Valkonen
2011-01-29 8:27 ` Dmitry Torokhov
2011-02-01 8:17 ` Valkonen, Iiro
2011-02-01 8:32 ` Dmitry Torokhov
2011-02-01 8:53 ` Valkonen, Iiro
2011-02-03 7:43 ` Dmitry Torokhov
2011-02-03 14:01 ` [PATCH 1/5] Remove fixed config data from driver file; add config to platform data Iiro Valkonen
2011-02-04 8:57 ` Dmitry Torokhov [this message]
2011-02-10 7:57 ` Iiro Valkonen
2011-02-18 14:21 ` Iiro Valkonen
2011-02-18 16:48 ` Dmitry Torokhov
2011-02-03 14:02 ` [PATCH 2/5] Read whole message instead of just the first byte to make CHG low Iiro Valkonen
2011-02-04 8:54 ` Dmitry Torokhov
2011-02-03 14:04 ` [PATCH 3/5] Skip matrix size check Iiro Valkonen
2011-02-04 8:59 ` Dmitry Torokhov
2011-02-11 13:32 ` Iiro Valkonen
2011-02-11 17:38 ` Dmitry Torokhov
2011-02-03 14:10 ` [PATCH 4/5] Try IRQF_TRIGGER_NONE if IRQF_TRIGGER_FALLING returns error Iiro Valkonen
2011-02-04 8:53 ` Dmitry Torokhov
2011-02-10 8:03 ` Iiro Valkonen
2011-02-03 14:13 ` [PATCH 5/5] Add chip I2C addresses to header file Iiro Valkonen
2011-02-03 14:49 ` Mark Brown
2011-02-04 8:37 ` Iiro Valkonen
2011-02-04 8:43 ` Dmitry Torokhov
2011-02-04 14:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204085754.GE13046@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=iiro.valkonen@atmel.com \
--cc=linux-input@vger.kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).