From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Iiro Valkonen <iiro.valkonen@atmel.com>
Cc: Trilok Soni <tsoni@codeaurora.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH 3/5] Skip matrix size check
Date: Fri, 4 Feb 2011 00:59:06 -0800 [thread overview]
Message-ID: <20110204085906.GF13046@core.coreip.homeip.net> (raw)
In-Reply-To: <4D4AB605.4080106@atmel.com>
On Thu, Feb 03, 2011 at 04:04:53PM +0200, Iiro Valkonen wrote:
> Input: qt602240_ts - Skip matrix size check
>
> From: Iiro Valkonen <iiro.valkonen@atmel.com>
>
> Skip the mxt224-specific matrix size check
>
> Signed-off-by: Iiro Valkonen <iiro.valkonen@atmel.com>
> ---
> drivers/input/touchscreen/qt602240_ts.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/touchscreen/qt602240_ts.c b/drivers/input/touchscreen/qt602240_ts.c
> index 6ef8290..a88ec93 100644
> --- a/drivers/input/touchscreen/qt602240_ts.c
> +++ b/drivers/input/touchscreen/qt602240_ts.c
> @@ -862,10 +862,17 @@ static int mxt_initialize(struct mxt_data *data)
> if (error)
> return error;
>
> + /*
> + * Skip this and trust what's on the chip, as the current check
> + * is not compatible with mXT1386. Revisit and fix.
> + */
> /* Check X/Y matrix size */
> +
> + /*
> error = mxt_check_matrix_size(data);
> if (error)
> return error;
> + */
No, this is not really acceptable for mainline... Please revisit now ;)
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-02-04 8:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 16:52 [PATCH] input: Modify the qt602240 driver to be compatible with mXT1386 device Iiro Valkonen
2011-01-24 17:07 ` Dmitry Torokhov
2011-01-25 10:33 ` [PATCH 1/2] input: Modify the qt602240 driver to be compatible with mXT1386 device - renames Iiro Valkonen
2011-01-25 11:00 ` Trilok Soni
2011-01-27 11:32 ` Trilok Soni
2011-02-01 8:45 ` Valkonen, Iiro
2011-02-03 7:29 ` Dmitry Torokhov
2011-01-25 10:37 ` [PATCH 2/2] input: Modify the qt602240 driver to be compatible with mXT1386 device - functional changes Iiro Valkonen
2011-01-29 8:27 ` Dmitry Torokhov
2011-02-01 8:17 ` Valkonen, Iiro
2011-02-01 8:32 ` Dmitry Torokhov
2011-02-01 8:53 ` Valkonen, Iiro
2011-02-03 7:43 ` Dmitry Torokhov
2011-02-03 14:01 ` [PATCH 1/5] Remove fixed config data from driver file; add config to platform data Iiro Valkonen
2011-02-04 8:57 ` Dmitry Torokhov
2011-02-10 7:57 ` Iiro Valkonen
2011-02-18 14:21 ` Iiro Valkonen
2011-02-18 16:48 ` Dmitry Torokhov
2011-02-03 14:02 ` [PATCH 2/5] Read whole message instead of just the first byte to make CHG low Iiro Valkonen
2011-02-04 8:54 ` Dmitry Torokhov
2011-02-03 14:04 ` [PATCH 3/5] Skip matrix size check Iiro Valkonen
2011-02-04 8:59 ` Dmitry Torokhov [this message]
2011-02-11 13:32 ` Iiro Valkonen
2011-02-11 17:38 ` Dmitry Torokhov
2011-02-03 14:10 ` [PATCH 4/5] Try IRQF_TRIGGER_NONE if IRQF_TRIGGER_FALLING returns error Iiro Valkonen
2011-02-04 8:53 ` Dmitry Torokhov
2011-02-10 8:03 ` Iiro Valkonen
2011-02-03 14:13 ` [PATCH 5/5] Add chip I2C addresses to header file Iiro Valkonen
2011-02-03 14:49 ` Mark Brown
2011-02-04 8:37 ` Iiro Valkonen
2011-02-04 8:43 ` Dmitry Torokhov
2011-02-04 14:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204085906.GF13046@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=iiro.valkonen@atmel.com \
--cc=linux-input@vger.kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).