From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Peter Korsgaard <jacmet@sunsite.dk>,
linux-input@vger.kernel.org, baruch@tkos.co.il
Subject: Re: [PATCHv2] evdev: fix evdev_write return value on partial writes
Date: Fri, 4 Feb 2011 09:15:19 -0800 [thread overview]
Message-ID: <20110204171519.GA14000@core.coreip.homeip.net> (raw)
In-Reply-To: <20110204112314.GA1501@polaris.bitmath.org>
On Fri, Feb 04, 2011 at 12:23:14PM +0100, Henrik Rydberg wrote:
> > Henrik> The code below will return -EINVAL even if some parts of the buffer
> > Henrik> was successfully read, though.
> >
> > You mean written? I don't see that. The only place we return -EINVAL is
> > at the initial check.
>
> Right, it should have been written, and -EFAULT, referring to the code
> in the loop.
>
If we faulted somewhere midway the only sane thing it to treat the whole
request as suspect and return -EFAULT. We really do not know what
happened to the other data (it could have gone past the buffer user
intended but haven't triggered the fault yet. We can't fully recover
either since we aleady retrievend the event that caused fault.
--
Dmitry
next prev parent reply other threads:[~2011-02-04 17:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 10:03 [PATCHv2] evdev: fix evdev_write return value on partial writes Peter Korsgaard
2011-01-27 11:02 ` Henrik Rydberg
2011-01-27 11:21 ` Peter Korsgaard
2011-01-27 11:26 ` Baruch Siach
2011-01-27 11:29 ` Peter Korsgaard
2011-01-27 11:47 ` Henrik Rydberg
2011-01-27 12:04 ` Peter Korsgaard
2011-01-27 12:26 ` Henrik Rydberg
2011-01-27 12:43 ` Peter Korsgaard
2011-02-04 8:46 ` Dmitry Torokhov
2011-02-04 10:24 ` Henrik Rydberg
2011-02-04 11:00 ` Peter Korsgaard
2011-02-04 11:23 ` Henrik Rydberg
2011-02-04 17:15 ` Dmitry Torokhov [this message]
2011-02-04 17:22 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204171519.GA14000@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=baruch@tkos.co.il \
--cc=jacmet@sunsite.dk \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).