From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sourav Poddar <sourav.poddar@ti.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Linux-Next <linux-next@vger.kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: drivers/input/touchscreen/ads7846.c:959: error: 'GPIOF_DIR_IN' undeclared
Date: Tue, 8 Feb 2011 13:10:36 -0800 [thread overview]
Message-ID: <20110208211035.GC16527@core.coreip.homeip.net> (raw)
In-Reply-To: <AANLkTim2706Negrvd-ektbNMLwucM9M0icphb_uFY_9D@mail.gmail.com>
On Tue, Feb 08, 2011 at 09:03:27PM +0100, Geert Uytterhoeven wrote:
> linux-next/m68k-allmodconfig/m68k:
> http://kisskb.ellerman.id.au/kisskb/buildresult/3899710/
>
> drivers/input/touchscreen/ads7846.c:959: error: 'GPIOF_DIR_IN'
> undeclared (first use in this function)
> drivers/input/touchscreen/ads7846.c:959: error: (Each undeclared
> identifier is reported only once
> drivers/input/touchscreen/ads7846.c:959: error: for each function it
> appears in.)
> make[4]: *** [drivers/input/touchscreen/ads7846.o] Error 1
>
> As of commit e9b6e245c727767e6d64cb3dd47a0c6982aa5d23
> ("Input: ads7846 - use gpio_request_one to configure pendown_gpio"), this
> driver should depend on GENERIC_GPIO?
> Else <linux/gpio.h> doesn't include <asm/gpio.h>, and we never see the
> definition of GPIOF_DIR_IN.
Crap, sorry about that, I'll fix it up tonight.
--
Dmitry
next prev parent reply other threads:[~2011-02-08 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 20:03 drivers/input/touchscreen/ads7846.c:959: error: 'GPIOF_DIR_IN' undeclared Geert Uytterhoeven
2011-02-08 21:10 ` Dmitry Torokhov [this message]
2011-02-08 21:20 ` Wolfram Sang
2011-02-09 7:34 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208211035.GC16527@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sourav.poddar@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).