linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jordi Pujol <jordipujolp@gmail.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] usbmouse: random freeze/hangup; synchronize irq completion
Date: Tue, 15 Feb 2011 11:30:30 +0100	[thread overview]
Message-ID: <201102151130.30998.jordipujolp@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1102140957180.1913-100000@iolanthe.rowland.org>

A Dilluns 14 Febrer 2011 16:00:24, Alan Stern va escriure:
> 	It calls mutex_lock(), which can sleep, from within an URB
> 	completion routine, which runs with interrupts disabled.
> 
> 	It doesn't synchronize the completion _with_ anything else,
> 	i.e., it calls mutex_lock() in only one place.
this routine is synchronized with himself.
I said synchronize thinking about synchronized routines that are pieces of 
code scheduled to be executed only in a single thread simultaneously; 
therefore a new call to this routine can not be executed until a previous call 
has been completed.

> 
> Whatever is causing your problem, this is not the proper solution.
Yes, that this is not a patch to be included in the kernel, it's only a 
testing patch, but it solves the hangup. and so this probes that there is some 
kind of problem related to the urb update process; I think the problem should 
be external to this routine.

searching the web, some people has found problems like this, example:
- [ubuntu] Ubuntu 10.04 (Lucid Lynx) Random Freeze / Hang-up

Consider this as an idea to point out the problem and, if possible, someone 
more expert help to look for a good solution.

Jordi Pujol

Live never ending Tale
GNU/Linux Live forever!
http://livenet.selfip.com

  reply	other threads:[~2011-02-15 10:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14  8:51 [PATCH] usbmouse: random freeze/hangup; synchronize irq completion Jordi Pujol
2011-02-14 15:00 ` Alan Stern
2011-02-15 10:30   ` Jordi Pujol [this message]
     [not found]     ` <201102151130.30998.jordipujolp-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-02-15 15:04       ` Alan Stern
     [not found] ` <201102140951.00866.jordipujolp-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-02-15  1:05   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102151130.30998.jordipujolp@gmail.com \
    --to=jordipujolp@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).